Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing capability #120771

Merged
merged 1 commit into from
Jan 24, 2025
Merged

Add missing capability #120771

merged 1 commit into from
Jan 24, 2025

Conversation

idegtiarenko
Copy link
Contributor

191_lookup_join_text.yml does not declare join_lookup_v11.
This causes yamlRestCompatTest test to fail for prs where a basic lookup join behavior is changed (for example in #120494) and above capability is incremented.

@idegtiarenko idegtiarenko added >test Issues or PRs that are addressing/adding tests Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) auto-backport Automatically create backport pull requests when merged :Analytics/ES|QL AKA ESQL v9.0.0 v8.18.0 labels Jan 24, 2025
idegtiarenko
idegtiarenko commented Jan 24, 2025
View reviewed changes
x-pack/plugin/src/yamlRestTest/resources/rest-api-spec/test/esql/191_lookup_join_text.yml
@@ -31,7 +31,6 @@ setup:
settings:
index:
mode: lookup
number_of_shards: 1
Copy link
Contributor Author

@idegtiarenko idegtiarenko Jan 24, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is unrelated but should no longer be required, see #119059

@elasticsearchmachine
Copy link
Collaborator

Pinging @elastic/es-analytical-engine (Team:Analytics)

@idegtiarenko idegtiarenko mentioned this pull request Jan 24, 2025
Merged
2 tasks
luigidellaquila
luigidellaquila approved these changes Jan 24, 2025
View reviewed changes
Copy link
Contributor

@luigidellaquila luigidellaquila left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I see other JOIN related capabilities check that JOIN_LOOKUP_V11 is enabled instead of checking on snapshot. An alternative could be LOOKUP_JOIN_TEXT(JOIN_LOOKUP_V11.isEnabled()), but I think the two are equivalent at this stage

@idegtiarenko idegtiarenko merged commit a82453a into elastic:main Jan 24, 2025
16 checks passed
@idegtiarenko idegtiarenko mentioned this pull request Jan 24, 2025
Merged
@elasticsearchmachine
Copy link
Collaborator

💚 Backport successful

Status Branch Result
✅ 8.x

@idegtiarenko idegtiarenko deleted the add_missing_capability branch January 24, 2025 08:49
elasticsearchmachine pushed a commit that referenced this pull request Jan 24, 2025
@idegtiarenko
Add missing capability (#120771) (#120777)
889b6ab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@luigidellaquila luigidellaquila luigidellaquila approved these changes

Assignees
No one assigned
Labels
:Analytics/ES|QL AKA ESQL auto-backport Automatically create backport pull requests when merged Team:Analytics Meta label for analytical engine team (ESQL/Aggs/Geo) >test Issues or PRs that are addressing/adding tests v8.18.0 v9.0.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@idegtiarenko @elasticsearchmachine @luigidellaquila