Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve unit test path filtering rules #2052

Merged
merged 3 commits into from
Nov 2, 2023
Merged

Improve unit test path filtering rules #2052

merged 3 commits into from
Nov 2, 2023

Conversation

JoshMock
Copy link
Member

@JoshMock JoshMock commented Nov 2, 2023

See docs about how jobs that are skipped still report success. When using paths-ignore the action does not run at all, so branch-protection rules are violated to merge a PR. Using the paths-filter action ensures the action does run, just skips tests and reports success.

Also stops running unit tests on push, as running on pull requests will trigger a rerun whenever new code is pushed to an open PR.

See docs about how jobs that are skipped still report "success", which
is necessary for jobs that are required to succeed based on branch
protection rules.

https://docs.github.com/en/actions/using-jobs/using-conditions-to-control-job-execution
Defaults are that it will run when a PR is opened, reopened, or
synchronized (new commits pushed).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant