Integration test: Fix yaml parser and crash on failure (#1423)

* Fix yaml parser and crash on failure * Log response in case of ResponseError * Updated cleanup * Updated skip list * Updated skip list * Updated skip list
elastic · Mar 24, 2021 · c8aae67 · c8aae67
1 parent 886289e
commit c8aae67
Show file tree

Hide file tree

Showing 3 changed files with 28 additions and 27 deletions.
diff --git a/test/integration/helper.js b/test/integration/helper.js
@@ -85,6 +85,8 @@ function isXPackTemplate (name) {
     case 'synthetics-mappings':
     case '.snapshot-blob-cache':
     case '.deprecation-indexing-template':
+    case '.deprecation-indexing-mappings':
+    case '.deprecation-indexing-settings':
       return true
   }
   return false

diff --git a/test/integration/index.js b/test/integration/index.js
@@ -83,6 +83,8 @@ const platinumBlackList = {
   ],
   // The cleanup fails with a index not found when retrieving the jobs
   'ml/get_datafeed_stats.yml': ['Test get datafeed stats when total_search_time_ms mapping is missing'],
+  // Investigate why is failing
+  'ml/inference_crud.yml': ['*'],
   // investigate why this is failing
   'monitoring/bulk/10_basic.yml': ['*'],
   'monitoring/bulk/20_privileges.yml': ['*'],
@@ -91,6 +93,7 @@ const platinumBlackList = {
   'snapshot/20_operator_privileges_disabled.yml': ['*'],
   // the body is correct, but the regex is failing
   'sql/sql.yml': ['Getting textual representation'],
+  'searchable_snapshots/10_usage.yml': ['*'],
   // we are setting two certificates in the docker config
   'ssl/10_basic.yml': ['*'],
   // very likely, the index template has not been loaded yet.
@@ -136,7 +139,15 @@ function runner (opts = {}) {
   const client = new Client(options)
   log('Loading yaml suite')
   start({ client, isXPack: opts.isXPack })
-    .catch(console.log)
+    .catch(err => {
+      if (err.name === 'ResponseError') {
+        console.error(err)
+        console.log(JSON.stringify(err.meta, null, 2))
+      } else {
+        console.error(err)
+      }
+      process.exit(1)
+    })
 }
 
 async function waitCluster (client, times = 0) {
@@ -303,10 +314,9 @@ function now () {
 }
 
 function parse (data) {
-  const schema = yaml.Schema.create(yaml.CORE_SCHEMA, [])
   let doc
   try {
-    doc = yaml.safeLoad(data, { schema })
+    doc = yaml.load(data, { schema: yaml.CORE_SCHEMA })
   } catch (err) {
     console.error(err)
     return

diff --git a/test/integration/test-runner.js b/test/integration/test-runner.js
@@ -95,32 +95,21 @@ function build (opts = {}) {
     // clean all indices
     await client.indices.delete({ index: '*,-.ds-ilm-history-*', expand_wildcards: 'open,closed,hidden' }, { ignore: [404] })
 
-    if (isXPack) {
-      // delete templates
-      const { body: templates } = await client.cat.templates({ h: 'name' })
-      for (const template of templates.split('\n').filter(Boolean)) {
-        if (isXPackTemplate(template)) continue
-        const { body } = await client.indices.deleteTemplate({ name: template }, { ignore: [404] })
-        if (JSON.stringify(body).includes(`index_template [${template}] missing`)) {
-          await client.indices.deleteIndexTemplate({ name: template }, { ignore: [404] })
-        }
-      }
-
-      // delete component template
-      const { body } = await client.cluster.getComponentTemplate()
-      const components = body.component_templates.filter(c => !isXPackTemplate(c.name)).map(c => c.name)
-      if (components.length > 0) {
-        await client.cluster.deleteComponentTemplate({ name: components.join(',') }, { ignore: [404] })
+    // delete templates
+    const { body: templates } = await client.cat.templates({ h: 'name' })
+    for (const template of templates.split('\n').filter(Boolean)) {
+      if (isXPackTemplate(template)) continue
+      const { body } = await client.indices.deleteTemplate({ name: template }, { ignore: [404] })
+      if (JSON.stringify(body).includes(`index_template [${template}] missing`)) {
+        await client.indices.deleteIndexTemplate({ name: template }, { ignore: [404] })
       }
-    } else {
-      // clean all templates
-      await client.indices.deleteTemplate({ name: '*' })
-
-      // clean all templates
-      await client.indices.deleteIndexTemplate({ name: '*' })
+    }
 
-      // clean all templates
-      await client.cluster.deleteComponentTemplate({ name: '*' })
+    // delete component template
+    const { body } = await client.cluster.getComponentTemplate()
+    const components = body.component_templates.filter(c => !isXPackTemplate(c.name)).map(c => c.name)
+    if (components.length > 0) {
+      await client.cluster.deleteComponentTemplate({ name: components.join(',') }, { ignore: [404] })
     }
 
     // Remove any cluster setting