-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds tests for Enterprise Search #84
Conversation
7824b57
to
7a7b1a8
Compare
bb1e781
to
45c4047
Compare
3a1c38c
to
5969a3d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I haven't re-added connector APIs to my generator so I can't run these tests locally yet. Have we verified those APIs are ready for 8.15? In any case, the tests look good!
Thanks Josh! The Connectors APIs are currently marked as "beta" in master: Ideally we shouldn't have to skip any tests with this new project, but I added that functionality to the new Ruby runner just in case. If I merge this, does it break the build for JS and others or can those tests be skipped if the APIs are not available? |
Nope, merge away! I already added skips for those tests. |
There are some new
entsearch
tests in the YAML Elasticsearch tests. They need the creation of two new users and roles. The users are created here asentsearch-user:entsearch-user-password
with the roleuser
: andentsearch-unprivileged:entsearch-unprivileged-password
with the roleunprivileged
. The role definitions can be found here.The build broke for the Ruby stack client and would need to be updated to address these failures. Instead, I'm going to skip those tests and migrate the tests here.
According to the generated report, we are back to (almost) 100% coverage for Serverless.
The three remaining APIs:
ml.flush_job
- We have Investigate why flush_job is failing sometimes #31 for this.security.update_api_key
- This is a tricky one. I tried adding it to our API key tests, but it was erroring. The docs say:It’s not possible to use an API key as the authentication credential for this API. To update an API key, the owner user’s credentials are required
. Our clients authenticate with API key, so I don't know if this would make sense to have this endpoint in the clients, as far as I understand, we can't use this API with API key? 🤷tasks.get
- is not available on Serverless: [410] api_not_available_exception - Request for uri [/_tasks/] with method [GET] exists but is not available when running in serverless mode