Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x](backport #6978) Fold triggered pipelines under elastic-agent #7041

Open
wants to merge 2 commits into
base: 8.x
Choose a base branch
from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 26, 2025

What does this PR do?

In order for the Buildkite PR bot to be able to publish meaningful comments for failures, the pipelines need to be collapsed / uploaded rather than triggered, otherwise we lose the context and the ability to have the comment include specific failures for the failed steps in triggered pipelines.

This commit switches away from triggering to pipeline upload commands to enable this functionality.

Why is it important?

Allows enabling ELASTIC_PR_COMMENTS_ENABLED: 'true' only on the parent job

Logs/Screenshots

Before (note the null which points to a triggered pipeline):

image

After, with this PR when there are failures:

image

and when tests pass after retries:

image


This is an automatic backport of pull request #6978 done by [Mergify](https://mergify.com).

In order for the Buildkite PR bot to be able to publish meaningful comments for failures, the pipelines need to be collapsed / uploaded rather than triggered, otherwise we lose the context and the ability to have the comment include specific failures for the failed steps in triggered pipelines.

This commit switches away from triggering to pipeline upload commands to enable this functionality.

(cherry picked from commit 33d0137)

# Conflicts:
#	.buildkite/bk.integration.pipeline.yml
@mergify mergify bot requested a review from a team as a code owner February 26, 2025 07:35
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Feb 26, 2025
Copy link
Contributor Author

mergify bot commented Feb 26, 2025

Cherry-pick of 33d0137 has failed:

On branch mergify/bp/8.x/pr-6978
Your branch is up to date with 'origin/8.x'.

You are currently cherry-picking commit 33d01371e.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   .buildkite/integration.pipeline.yml
	modified:   .buildkite/pipeline.yml

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   .buildkite/bk.integration.pipeline.yml

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@elasticmachine
Copy link
Contributor

elasticmachine commented Feb 26, 2025

💔 Build Failed

Failed CI Steps

History

cc @dliappis

Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@dliappis dliappis removed the conflicts There is a conflict in the backported pull request label Feb 26, 2025
Copy link
Contributor

@pazone pazone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants