-
Notifications
You must be signed in to change notification settings - Fork 154
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[9.0](backport #6630) [Managed OTLP] Add Host/K8s onboarding configurations #6976
Open
mergify
wants to merge
4
commits into
9.0
Choose a base branch
from
mergify/bp/9.0/pr-6630
base: 9.0
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* feat: remove apm-processing from gateway collector * remove elasticsearch exporter in favor of managed otlp * update darwin configurations * refactor: move motel values to motel dir * add ApiKey prefix for motel exporter headers * refactor: move motel configurations to motel subdir * test: add motel configuration integration test case * chore: add fragments entry * refactor: use managed_otlp directory * fix: mock a valid ingest endpoint url * chore: remove MOtel in favor of Managed OTLP Input * increase gateway resource limits * use ELASTIC_OTLP_ENDPOINT as secret and env variable * never split metrics requests in batchprocessor * update env variable on host configuration * gateway: use autoscaler instead of fixed replicas (cherry picked from commit c1d42ae)
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
This pull request has not been merged yet. Could you please review and merge it @rogercoll? 🙏 |
rogercoll
approved these changes
Feb 24, 2025
swiatekm
approved these changes
Feb 24, 2025
💔 Build Failed
Failed CI StepsHistory
cc @rogercoll |
2 tasks
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the configuration files for the EDOT collector that will be provided during the Kibana's OpenTelemetry Host and K8s onboarding flow for MOTel.
The files are a copy of the current sample configurations but replacing how the data is forwarded, instead of using the Elasticsearch exporter + Elastic processors/connector for data transformations, it directly sends the gathered OTLP signals to an OTLP ingest endpoint. For the Helm values file, only the
gateway
collector configuration has been modified.Usage (Kibana)
Kibana instructions will point to the MOTel configuration (
managed_otlp
dir) or the managed one, depending on if it's a serverless env or not:Tests
Added an integration test for the new Helm configuration in
testing/integration/otel_helm_test.go
. TheELASTIC_ENDPOINT
andELASTIC_APIKEY
values used during the test do not point to any real environment (MOTel only available in serverless atm), but currently we are only validating that the K8s pods are being created (no error in the config).Alternative solutions
Unify data collection configurations
Managed and MOTel sample configurations share the same data collection settings. To simplify maintenance, it's preferable to reference a single configuration file. For the Helm deployment, we could do the following:
The same strategy could be applied for the
onhost
configurations, move the processing, exporters and pipelines configuration in a separate files and launch the collector by merging two configs:This solution eases the configuration maintainability (e.g. bumping deps), but at the cost of usability (two related configuration files).
cc @mlunadia
This is an automatic backport of pull request #6630 done by Mergify.