Fix warning on emitting diagnostics for otel hybrid mode #6973
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If an Otel hybrid mode configuration doesn't exist, we emit a plain text message into the config file generated by diagnostics. When we try to redact secrets from it, we fail to unmarshal it into a map and log a warning about it. Instead, only run the redaction after confirming the value is actually a map.
swiatekm
added
bug
|
Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane) |
|
pkoutsovasilis
approved these changes
Feb 24, 2025
mergify bot
pushed a commit
that referenced
this pull request
Feb 26, 2025
If an Otel hybrid mode configuration doesn't exist, we emit a plain text message into the config file generated by diagnostics. When we try to redact secrets from it, we fail to unmarshal it into a map and log a warning about it. Instead, only run the redaction after confirming the value is actually a map. (cherry picked from commit 087cfb3)
4 tasks
mergify bot
pushed a commit
that referenced
this pull request
Feb 26, 2025
If an Otel hybrid mode configuration doesn't exist, we emit a plain text message into the config file generated by diagnostics. When we try to redact secrets from it, we fail to unmarshal it into a map and log a warning about it. Instead, only run the redaction after confirming the value is actually a map. (cherry picked from commit 087cfb3)
mergify bot
pushed a commit
that referenced
this pull request
Feb 26, 2025
If an Otel hybrid mode configuration doesn't exist, we emit a plain text message into the config file generated by diagnostics. When we try to redact secrets from it, we fail to unmarshal it into a map and log a warning about it. Instead, only run the redaction after confirming the value is actually a map. (cherry picked from commit 087cfb3)
This was referenced Feb 26, 2025
mergify bot
pushed a commit
that referenced
this pull request
Feb 26, 2025
If an Otel hybrid mode configuration doesn't exist, we emit a plain text message into the config file generated by diagnostics. When we try to redact secrets from it, we fail to unmarshal it into a map and log a warning about it. Instead, only run the redaction after confirming the value is actually a map. (cherry picked from commit 087cfb3)
4 tasks
swiatekm
added a commit
that referenced
this pull request
Feb 26, 2025
If an Otel hybrid mode configuration doesn't exist, we emit a plain text message into the config file generated by diagnostics. When we try to redact secrets from it, we fail to unmarshal it into a map and log a warning about it. Instead, only run the redaction after confirming the value is actually a map. (cherry picked from commit 087cfb3) Co-authored-by: Mikołaj Świątek <[email protected]>
swiatekm
added a commit
that referenced
this pull request
Feb 26, 2025
If an Otel hybrid mode configuration doesn't exist, we emit a plain text message into the config file generated by diagnostics. When we try to redact secrets from it, we fail to unmarshal it into a map and log a warning about it. Instead, only run the redaction after confirming the value is actually a map. (cherry picked from commit 087cfb3) Co-authored-by: Mikołaj Świątek <[email protected]>
swiatekm
added a commit
that referenced
this pull request
Feb 26, 2025
If an Otel hybrid mode configuration doesn't exist, we emit a plain text message into the config file generated by diagnostics. When we try to redact secrets from it, we fail to unmarshal it into a map and log a warning about it. Instead, only run the redaction after confirming the value is actually a map. (cherry picked from commit 087cfb3) Co-authored-by: Mikołaj Świątek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
If an Otel hybrid mode configuration doesn't exist, we emit a plain text message into the config file generated by diagnostics. When we try to redact secrets from it, we fail to unmarshal it into a map and log a warning about it.
Instead, only run the redaction after confirming the value is actually a map.
Why is it important?
We shouldn't emit spurious warnings.
Checklist
How to test this PR locally
Build the agent locally, start it, and get diagnostics. You shouldn't see a warning message mentioned in #6783.
Related issues
Could not redact otel.yamlerror on running elastic-agent diagnostics command. #6783