Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace x/exp usage with iterators #6933

Merged
merged 3 commits into from
Feb 20, 2025

Conversation

kruskall
Copy link
Member

What does this PR do?

go 1.23 added iterators, let's use them

Why is it important?

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Disruptive User Impact

How to test this PR locally

Related issues

Questions to ask yourself

  • How are we going to support this in production?
  • How are we going to measure its adoption?
  • How are we going to debug this?
  • What are the metrics I should take care of?
  • ...

go 1.23 added iterators, let's use them
@kruskall kruskall requested a review from a team as a code owner February 19, 2025 20:21
Copy link
Contributor

mergify bot commented Feb 19, 2025

This pull request does not have a backport label. Could you fix it @kruskall? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-./d./d is the label that automatically backports to the 8./d branch. /d is the digit
  • backport-active-all is the label that automatically backports to all active branches.
  • backport-active-8 is the label that automatically backports to all active minor branches for the 8 major.
  • backport-active-9 is the label that automatically backports to all active minor branches for the 9 major.

@cmacknz cmacknz added the backport-8.x Automated backport to the 8.x branch with mergify label Feb 19, 2025
@kruskall kruskall enabled auto-merge (squash) February 19, 2025 22:06
@kruskall kruskall disabled auto-merge February 19, 2025 22:06
@kruskall kruskall enabled auto-merge (squash) February 19, 2025 22:06
Copy link

@kruskall kruskall merged commit b16c581 into elastic:main Feb 20, 2025
14 checks passed
@kruskall kruskall deleted the feat/drop-exp branch February 20, 2025 14:12
mergify bot pushed a commit that referenced this pull request Feb 20, 2025
* refactor: replace x/exp usage with iterators

go 1.23 added iterators, let's use them

* Update container_init_test.go

* Update container_init_test.go

(cherry picked from commit b16c581)
dliappis added a commit to dliappis/elastic-agent that referenced this pull request Feb 20, 2025
dliappis added a commit that referenced this pull request Feb 20, 2025
kruskall added a commit that referenced this pull request Feb 21, 2025
* refactor: replace x/exp usage with iterators

go 1.23 added iterators, let's use them

* Update container_init_test.go

* Update container_init_test.go

(cherry picked from commit b16c581)

Co-authored-by: kruskall <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify refactoring skip-changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants