Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[9.0](backport #6866) fix install prevention on Linux #6923

Merged
merged 1 commit into from
Feb 19, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 19, 2025

What does this PR do?

go-sysinfo determines native architecture based on /proc filesystem which could be disabled, therefore the prevention should err on allowing installation when native architecture is unknown.

The fixed prevention was not included in any released version yet.

Why is it important?

Agent prevents adding Elastic Defend when it cannot determine if it's being emulated. However it's fine to install Elastic Defend in such case, as it does emulation check on it's own upon installation returning installation error when appropriate.

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Related issues


This is an automatic backport of pull request #6866 done by [Mergify](https://mergify.com).

* fix install prevention on Linux

* changelog

* remove changelog fragment as the bug didn't land in any release yet

* upgate go-sysinfo module

* go mod tidy

* notice

* CRLF to LF

(cherry picked from commit f7fc674)
@mergify mergify bot requested a review from a team as a code owner February 19, 2025 09:25
@mergify mergify bot added the backport label Feb 19, 2025
@mergify mergify bot requested review from michalpristas and pchila and removed request for a team February 19, 2025 09:25
@mergify mergify bot assigned intxgo Feb 19, 2025
@github-actions github-actions bot added bug Something isn't working Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team skip-changelog labels Feb 19, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@intxgo intxgo enabled auto-merge (squash) February 19, 2025 10:09
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarQube

@intxgo intxgo merged commit de771f5 into 9.0 Feb 19, 2025
16 checks passed
@intxgo intxgo deleted the mergify/bp/9.0/pr-6866 branch February 19, 2025 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport bug Something isn't working skip-changelog Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants