Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x](backport #6894) Add a test for empty local provider #6916

Merged
merged 1 commit into from
Feb 18, 2025

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Feb 18, 2025

What does this PR do?

Adds a test verifying that the composable provider will correctly emit variables if only an empty local provider is present. #6598 fixed a bug related to this in 8.17 and 8.16. The bug doesn't exist in newer versions due to #6169.

Why is it important?

Before #6169 allowed providers to not run if there weren't any references to them in the policy, adding an empty local provider was how users would intentionally disable providers. This test case verifies that newer versions of agent don't break this setup.

Checklist

  • I have read and understood the pull request guidelines of this project.
  • My code follows the style guidelines of this project
  • I have added tests that prove my fix is effective or that my feature works

This is an automatic backport of pull request #6894 done by [Mergify](https://mergify.com).

@mergify mergify bot requested a review from a team as a code owner February 18, 2025 16:09
@mergify mergify bot added the backport label Feb 18, 2025
@mergify mergify bot requested review from michalpristas and pchila and removed request for a team February 18, 2025 16:09
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@swiatekm swiatekm enabled auto-merge (squash) February 18, 2025 16:37
Copy link

@swiatekm swiatekm merged commit 57b9192 into 8.x Feb 18, 2025
16 checks passed
@swiatekm swiatekm deleted the mergify/bp/8.x/pr-6894 branch February 18, 2025 21:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants