Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix go vet errors with Go 1.24 #5651

Merged
merged 1 commit into from
Oct 3, 2024
Merged

fix go vet errors with Go 1.24 #5651

merged 1 commit into from
Oct 3, 2024

Conversation

mauri870
Copy link
Member

@mauri870 mauri870 commented Oct 1, 2024 •
edited
Loading

What does this PR do?

The cmd/vet in Go 1.24 reports printf calls with non-const format and no args, causing failures.

How to test this PR locally

$ go install golang.org/dl/gotip@latest
$ gotip download
$ gotip vet ./...

Related issues

@mauri870 mauri870 added Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team Cleanup backport-8.x Automated backport to the 8.x branch with mergify labels Oct 1, 2024
@mauri870 mauri870 marked this pull request as ready for review October 1, 2024 17:02
@mauri870 mauri870 requested a review from a team as a code owner October 1, 2024 17:02
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@elastic-sonarqube Elastic SonarQube
Copy link

Quality Gate passed Quality Gate passed

Issues
0 New issues
0 Fixed issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube

michel-laterman
michel-laterman approved these changes Oct 1, 2024
View reviewed changes
Copy link
Contributor

@michel-laterman michel-laterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@pierrehilbert pierrehilbert merged commit 11cb0a9 into elastic:main Oct 3, 2024
14 of 18 checks passed
mergify bot pushed a commit that referenced this pull request Oct 3, 2024
@mauri870 @mergify
fix go vet errors with Go 1.24 (#5651)
d641240 
(cherry picked from commit 11cb0a9)
@mergify mergify bot mentioned this pull request Oct 3, 2024
Merged
mauri870 added a commit that referenced this pull request Oct 3, 2024
@mergify @mauri870
fix go vet errors with Go 1.24 (#5651) (#5684)
f067c92 
(cherry picked from commit 11cb0a9)

Co-authored-by: Mauri de Souza Meneguzzo <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blakerouse blakerouse blakerouse approved these changes

@michel-laterman michel-laterman michel-laterman approved these changes

@pkoutsovasilis pkoutsovasilis Awaiting requested review from pkoutsovasilis pkoutsovasilis is a code owner automatically assigned from elastic/elastic-agent-control-plane

Assignees

@mauri870 mauri870

Labels
backport-8.x Automated backport to the 8.x branch with mergify Cleanup skip-changelog Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mauri870 @elasticmachine @blakerouse @michel-laterman @pierrehilbert