Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Kubernetes] Check AddResourceMetadata and hints before starting namespace and node watchers #4618

Merged

Conversation

constanca-m
Copy link
Contributor

@constanca-m constanca-m commented Apr 24, 2024

What does this PR do?

Check AddResourceMetadata and hints before starting namespace and node watchers.

This PR is to sync beats with the agent. Change in beats was done in this PR, and issue is this one.

Why is it important?

See issue.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Related issues

Closes elastic/beats#37179.

@constanca-m constanca-m self-assigned this Apr 24, 2024
@constanca-m constanca-m requested a review from a team as a code owner April 24, 2024 08:20
@constanca-m constanca-m requested review from gizas and gsantoro April 24, 2024 08:20
Copy link
Contributor

mergify bot commented Apr 24, 2024

This pull request does not have a backport label. Could you fix it @constanca-m? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@constanca-m constanca-m requested a review from a team as a code owner April 24, 2024 08:23
@constanca-m constanca-m added Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team and removed backport-skip labels Apr 24, 2024
Copy link
Contributor

mergify bot commented Apr 24, 2024

This pull request does not have a backport label. Could you fix it @constanca-m? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

Copy link
Contributor

@blakerouse blakerouse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Just a minor fix on the changelog.

@constanca-m constanca-m enabled auto-merge (squash) April 25, 2024 08:12
@constanca-m constanca-m merged commit 5503e4c into elastic:main Apr 25, 2024
9 checks passed
@constanca-m constanca-m deleted the remove-mandatory-ns-node-permissions branch April 25, 2024 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Team:Cloudnative-Monitoring Label for the Cloud Native Monitoring team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Metricbeat Autodiscover] Provider Kubernetes always creates watcher for namespaces and nodes
3 participants