Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Could not redact otel.yaml error on running elastic-agent diagnostics command. #6783

Closed
amolnater-qasource opened this issue Feb 10, 2025 · 4 comments · Fixed by #6973
Closed
Assignees
Labels
bug Something isn't working impact:medium QA:Ready For Testing Code is merged and ready for QA to validate Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Comments

@amolnater-qasource
Copy link

Kibana Build details:

VERSION: 9.0.0 beta1 BC2
BUILD: 83474
COMMIT: 88aa3d3604b2c71e998595c3208b3d82cef24d2a

https://staging.elastic.co/9.0.0-beta1-191089b1/summary-9.0.0-beta1.html

Preconditions:

  1. 9.0.0 beta BC1 Kibana cloud environment should be available.
  2. An agent should be installed.

Steps to reproduce:

  1. Navigate to CLI.
  2. Run: elastic-agent diagnostics collect command.
  3. Observe warning: Could not redact otel.yaml.

Expected Result:
Diagnostics zip should be created completely on running elastic-agent diagnostics command.

Screenshot:

Image

@amolnater-qasource amolnater-qasource added bug Something isn't working impact:medium Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team labels Feb 10, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@amolnater-qasource
Copy link
Author

@muskangulati-qasource Please review.

@muskangulati-qasource
Copy link

Secondary review is Done for this ticket!

@swiatekm
Copy link
Contributor

The reason for this is that if we don't have an otel config, we output the string no active OTel configuration instead. Redaction of secrets fails on this string because it expects a map instead. We should probably unmarshal to any and then use reflection to check if the value is a map first.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working impact:medium QA:Ready For Testing Code is merged and ready for QA to validate Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants