Skip to content
This repository has been archived by the owner on Sep 21, 2023. It is now read-only.

Migrate the elasticsearch output to go-elasticsearch #187

Merged
merged 16 commits into from
Dec 1, 2022

Conversation

faec
Copy link
Contributor

@faec faec commented Nov 22, 2022

What does this PR do?

Migrate the Elasticsearch output from the old custom client library in libbeat to the official go-elasticsearch client.

Closes #14.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.md or CHANGELOG-developer.md.

@faec faec added enhancement New feature or request Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team labels Nov 22, 2022
@faec faec requested a review from a team as a code owner November 22, 2022 20:25
@faec faec requested review from fearful-symmetry and leehinman and removed request for a team November 22, 2022 20:25
@mergify mergify bot assigned faec Nov 22, 2022
@mergify
Copy link
Contributor

mergify bot commented Nov 22, 2022

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @faec? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@elasticmachine
Copy link
Collaborator

elasticmachine commented Nov 22, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-11-30T18:53:48.441+0000

  • Duration: 15 min 18 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

Copy link
Contributor

@leehinman leehinman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like how this is simplifying things.

output/elasticsearch/output.go Show resolved Hide resolved
output/elasticsearch/output.go Show resolved Hide resolved
queue/queue.go Outdated Show resolved Hide resolved
@mergify
Copy link
Contributor

mergify bot commented Nov 28, 2022

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b esclient upstream/esclient
git merge upstream/main
git push upstream esclient

@cmacknz
Copy link
Member

cmacknz commented Dec 1, 2022

I really like how this is simplifying things.

Agree, took a quick look and this is looking good. Thanks @faec!

To one of Lee's points, let's make sure we have all the follow up work accurately captured into issues so we have a good view of what work is left. There was a preliminary list tracked under "Implement an Elasticsearch output" on #16 that may now be out of date.

One issue we may want to follow is elastic/go-elasticsearch#557. We aren't at the point of performance testing yet where this would come up, but we'll get there eventually.

@faec faec merged commit c272f44 into elastic:main Dec 1, 2022
@faec faec deleted the esclient branch December 1, 2022 21:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use the go-elasticsearch client for the Elasticsearch output
4 participants