-
Notifications
You must be signed in to change notification settings - Fork 17
Migrate the elasticsearch output to go-elasticsearch #187
Conversation
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I really like how this is simplifying things.
This pull request is now in conflicts. Could you fix it? 🙏
|
Agree, took a quick look and this is looking good. Thanks @faec! To one of Lee's points, let's make sure we have all the follow up work accurately captured into issues so we have a good view of what work is left. There was a preliminary list tracked under "Implement an Elasticsearch output" on #16 that may now be out of date. One issue we may want to follow is elastic/go-elasticsearch#557. We aren't at the point of performance testing yet where this would come up, but we'll get there eventually. |
What does this PR do?
Migrate the Elasticsearch output from the old custom client library in libbeat to the official
go-elasticsearch
client.Closes #14.
Checklist
I have made corresponding changes to the documentationI have made corresponding change to the default configuration filesI have added tests that prove my fix is effective or that my feature worksI have added an entry inCHANGELOG.md
orCHANGELOG-developer.md
.