Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[tlscommon] Add test helper methods #269

Merged
merged 2 commits into from
Jan 29, 2025
Merged

[tlscommon] Add test helper methods #269

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1b56b2a
[tlscommon] Add test helper methods
khushijain21 Jan 28, 2025
c3b89bc
Merge remote-tracking branch 'refs/remotes/upstream/main' into genTest2
khushijain21 Jan 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
148 changes: 0 additions & 148 deletions transport/tlscommon/ca_pinning_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,19 +20,12 @@ package tlscommon
import (
"bytes"
"context"
"crypto/rand"
"crypto/rsa"
"crypto/sha256"
"crypto/tls"
"crypto/x509"
"crypto/x509/pkix"
"fmt"
"math/big"
"net"
"net/http"
"strings"
"testing"
"time"

"github.com/stretchr/testify/assert"
"github.com/stretchr/testify/require"
Expand All @@ -41,8 +34,6 @@ import (
"github.com/elastic/elastic-agent-libs/iobuf"
)

var ser int64 = 1

func TestCAPinning(t *testing.T) {
const (
host = "127.0.0.1"
Expand Down Expand Up @@ -310,142 +301,3 @@ func TestCAPinning(t *testing.T) {
require.Error(t, err)
})
}

func genCA() (tls.Certificate, error) {
ca := &x509.Certificate{
SerialNumber: serial(),
Subject: pkix.Name{
CommonName: "localhost",
Organization: []string{"TESTING"},
Country: []string{"CANADA"},
Province: []string{"QUEBEC"},
Locality: []string{"MONTREAL"},
StreetAddress: []string{"testing road"},
PostalCode: []string{"HOH OHO"},
},
NotBefore: time.Now(),
NotAfter: time.Now().Add(1 * time.Hour),
IsCA: true,
ExtKeyUsage: []x509.ExtKeyUsage{x509.ExtKeyUsageClientAuth, x509.ExtKeyUsageServerAuth},
KeyUsage: x509.KeyUsageDigitalSignature | x509.KeyUsageCertSign,
BasicConstraintsValid: true,
}

caKey, err := rsa.GenerateKey(rand.Reader, 2048) // less secure key for quicker testing.
if err != nil {
return tls.Certificate{}, fmt.Errorf("fail to generate RSA key: %w", err)
}

ca.SubjectKeyId = generateSubjectKeyID(&caKey.PublicKey)

caBytes, err := x509.CreateCertificate(rand.Reader, ca, ca, &caKey.PublicKey, caKey)
if err != nil {
return tls.Certificate{}, fmt.Errorf("fail to create certificate: %w", err)
}

leaf, err := x509.ParseCertificate(caBytes)
if err != nil {
return tls.Certificate{}, fmt.Errorf("fail to parse certificate: %w", err)
}

return tls.Certificate{
Certificate: [][]byte{caBytes},
PrivateKey: caKey,
Leaf: leaf,
}, nil
}

// genSignedCert generates a CA and KeyPair and remove the need to depends on code of agent.
func genSignedCert(
ca tls.Certificate,
keyUsage x509.KeyUsage,
isCA bool,
commonName string,
dnsNames []string,
ips []net.IP,
expired bool,
) (tls.Certificate, error) {
if commonName == "" {
commonName = "You know, for search"
}

notBefore := time.Now()
notAfter := notBefore.Add(5 * time.Hour)

if expired {
notBefore = notBefore.Add(-42 * time.Hour)
notAfter = notAfter.Add(-42 * time.Hour)
}
// Create another Cert/key
cert := &x509.Certificate{
SerialNumber: big.NewInt(2000),

// SNA - Subject Alternative Name fields
IPAddresses: ips,
DNSNames: dnsNames,

Subject: pkix.Name{
CommonName: commonName,
Organization: []string{"TESTING"},
Country: []string{"CANADA"},
Province: []string{"QUEBEC"},
Locality: []string{"MONTREAL"},
StreetAddress: []string{"testing road"},
PostalCode: []string{"HOH OHO"},
},

NotBefore: notBefore,
NotAfter: notAfter,
IsCA: isCA,
ExtKeyUsage: []x509.ExtKeyUsage{x509.ExtKeyUsageClientAuth, x509.ExtKeyUsageServerAuth},
KeyUsage: keyUsage,
BasicConstraintsValid: true,
}

certKey, err := rsa.GenerateKey(rand.Reader, 2048)
if err != nil {
return tls.Certificate{}, fmt.Errorf("fail to generate RSA key: %w", err)
}

if isCA {
cert.SubjectKeyId = generateSubjectKeyID(&certKey.PublicKey)
}

certBytes, err := x509.CreateCertificate(
rand.Reader,
cert,
ca.Leaf,
&certKey.PublicKey,
ca.PrivateKey,
)

if err != nil {
return tls.Certificate{}, fmt.Errorf("fail to create signed certificate: %w", err)
}

leaf, err := x509.ParseCertificate(certBytes)
if err != nil {
return tls.Certificate{}, fmt.Errorf("fail to parse the certificate: %w", err)
}

return tls.Certificate{
Certificate: [][]byte{certBytes},
PrivateKey: certKey,
Leaf: leaf,
}, nil
}

func serial() *big.Int {
ser = ser + 1
return big.NewInt(ser)
}

func generateSubjectKeyID(publicKey *rsa.PublicKey) []byte {
// SubjectKeyId generated using method 1 in RFC 7093, Section 2:
// 1) The keyIdentifier is composed of the leftmost 160-bits of the
// SHA-256 hash of the value of the BIT STRING subjectPublicKey
// (excluding the tag, length, and number of unused bits).
publicKeyBytes := x509.MarshalPKCS1PublicKey(publicKey)
h := sha256.Sum256(publicKeyBytes)
return h[:20]
}
Loading
Loading