Add Close method to logp.Logger #205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a close method to logp.Logger responsible for closing any underlying core/output. All of our implementations of zapcore.Core that use an output that can be closed now implement io.Closer. This allows for closing any underlying files used by any output, which can prevent issues on Windows.
belimawr
requested review from
rdner and
fearful-symmetry
and removed request for
a team
This commit removes a workaround for windows because the log files could not be closed.
pierrehilbert
added
the
Team:Elastic-Agent-Data-Plane
rdner
approved these changes
May 20, 2024
|
looks like the tests found some issues though. |
|
buildkite test this |
💚 Build Succeeded
History
cc @belimawr |
This was referenced May 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add a close method to logp.Logger responsible for closing any underlying core/output. All of our implementations of zapcore.Core that use an output that can be closed now implement io.Closer.
This allows for closing any underlying files used by any output, which can prevent issues on Windows.
It also removes the workaround for testing the loggers on Windows.
Why is it important?
It allows us to correctly close any underlying file descriptor used by our loggers. This allows us to make sure no log data is lost as well as prevent issues on Windows where folders containing active log files cannot be removed by the Elastic-Agent
Checklist
## Author's ChecklistRelated issues
logp.Loggershould expose aClosemethod to close any open files #179