add ServerConfig tags, export TLSClientAuth #176
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
michel-laterman
requested review from
belimawr and
fearful-symmetry
and removed request for
a team
michel-laterman
commented
Jan 10, 2024
| CAs: []string{"/path/to/ca.crt"}, | ||
| ClientAuth: TLSClientAuthNone, | ||
| }, | ||
| clientAuth: TLSClientAuthNone, // FIXME test fails, it serializes to required |
There was a problem hiding this comment.
This test is failing because of the omitempty tag on the ClientAuth attribute of the struct.
TLSClientAuthNone corresponds with a zero value, so it will not be serialized if it is set in the struct.
If we remove the omitempty tag, the "with ca" unit test will fail (none will serialize, and the Unpack method will not insert the required val (current default when a CA is specified).
I can try to change ClientAuth to be a pointer value instead, so there is a difference between no value, and a none (0) val
michel-laterman
commented
Jan 11, 2024
💚 Build Succeeded
History
|
blakerouse
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
add ServerConfig tags, export TLSClientAuth
Why is it important?
We want to enable mTLS args as part of elastic-agent's CLI. These args should be parsed and passed to fleet-server. YAML tags are needed to allow for serialization.