feat: expose DialContext in Dialer and propagate context #165
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
A dialer only exposed the Dial method, making it impossible to correctly propagate context along with timeouts and cancellations.
This PR exposes
DialContext
in the dialer interface.The
Dial
method is kept for backward compatibility.Why is it important?
We're using
NetDialer
to create a dialer in apm-server but we are forced to pass theDial
method to thehttp.Transport
becauseDialContext
is not exposed.This prevents the context from being propagated
Checklist
CHANGELOG.md
Author's Checklist
Related issues