Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accommodate sticky marketing nav #3126

Merged
merged 2 commits into from
Nov 22, 2024

Conversation

colleenmcginnis
Copy link
Contributor

It looks like the marketing nav is now sticky when you scroll down the page. As a result it's covering the book title and version dropdown on the left and part of the "On this page" section on the right.

Before marketing nav change Now (with sticky marketing nav)
Screenshot 2024-11-21 at 5 58 23 PM Screenshot 2024-11-21 at 5 57 45 PM

This PR adjusts the CSS to accommodate the new nav behavior. This fix is pretty fragile — if the height of the nav at any screen width changes, the docs content may have too much or too little space at the top. I'm not sure if there's a better solution.

@colleenmcginnis colleenmcginnis self-assigned this Nov 22, 2024
Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@colleenmcginnis colleenmcginnis marked this pull request as ready for review November 22, 2024 14:28
@colleenmcginnis colleenmcginnis requested a review from a team as a code owner November 22, 2024 14:28
@dedemorton
Copy link
Contributor

dedemorton commented Nov 22, 2024

I'm going to approve this because I think it's better than how the site currently behaves (still not great).
However it would be better to find a long-term solution that is not fragile. It would also be better if we had a chance to test changes like this before they get dumped on our users.

IMO the heavyweight nature of the site menu (with large popups that users can easily trigger by mistake) makes it really intrusive for users who are simply trying to read the docs.

Every time I accidentally trigger those popups (which is pretty much every time I try to click a breadcrumb), I feel instantly pissed off and wonder if users are experiencing the same feelings.

People who read the docs go there for a very different reason than casual site visitors who are trying to learn about Elastic. Users of the documentation should not have to be distracted by popups (or a menu bar) that they don't care about.

@colleenmcginnis colleenmcginnis merged commit 0b6d2b3 into elastic:master Nov 22, 2024
3 checks passed
@colleenmcginnis colleenmcginnis deleted the sticky-marketing-nav branch November 22, 2024 19:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants