Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop keep-hash fro docs PR builds #2860

Merged
merged 1 commit into from
Dec 11, 2023
Merged

Drop keep-hash fro docs PR builds #2860

merged 1 commit into from
Dec 11, 2023

Conversation

nkammah
Copy link
Contributor

@nkammah nkammah commented Dec 11, 2023

@github-actions GitHub Actions
Copy link

A documentation preview will be available soon.
Help us out by validating the Buildkite preview and reporting issues here.

@bmorelli25 bmorelli25 mentioned this pull request Dec 11, 2023
Closed
@bmorelli25
Copy link
Member

Thanks! Will wait for checks to pass before reviewing. This PR replaces #2859.

bmorelli25
bmorelli25 approved these changes Dec 11, 2023
View reviewed changes
Copy link
Member

@bmorelli25 bmorelli25 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀 Looks good to me

@nkammah nkammah merged commit 84dbe94 into master Dec 11, 2023
7 checks passed
@nkammah nkammah deleted the fix-bk-builds-docs-repo branch December 11, 2023 19:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bmorelli25 bmorelli25 bmorelli25 approved these changes

@colleenmcginnis colleenmcginnis Awaiting requested review from colleenmcginnis

@kilfoyle kilfoyle Awaiting requested review from kilfoyle

@leemthompo leemthompo Awaiting requested review from leemthompo

@scottybollinger scottybollinger Awaiting requested review from scottybollinger scottybollinger was automatically assigned from elastic/docs-engineering

@glitteringkatie glitteringkatie Awaiting requested review from glitteringkatie glitteringkatie was automatically assigned from elastic/docs-engineering

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nkammah @bmorelli25