-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Docs migration batch3 #2856
Docs migration batch3 #2856
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm less certain of the non-Observability repositories, but everything I seen in Observability looks good. I can reach out to the individual teams to see if they want comments added to their PRs, but most of them don't have this currently and likely won't want it.
I'm waiting for the Clients team to confirm the logic for the following repos: elastic/elasticsearch-net It seems like the logic should be only when the docs directory changes, but they may know something I don't. |
I followed the following logic:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I can follow up if any changes are needed for client repos.
This PR adds the remaining repositories to the Buildkite job rollout - see comm email about it.
Note to reviewers (ideally doc point persons):
1. Validate the build avoidance logic (if applicable)
The Buildkite PR bot has some build avoidance logic in place. Some repositories are configured to have the docs PR job for any changes in the repo. Other are configured for changes in the "docs" folder only.. I tried to follow the docs script build avoidance logic to determine how the repo should be configured, but you need to validate that this is actually the case.
Repos configured to trigger PR on
every
changesRepos configured to trigger PR on changes in the
docs
folder only2. Setup or update your GH action
As mentioned in the comm email, you can setup a GitHub action that posts a comment with various links to validate the doc
Here's an example setup you can copy in your repo.
3. Assess if you anticipate potential conflicts with other Buildkite pipelines in your repository
The docs PR job leverages the Buildkite PR bot. Before merging this PR, I will setup a webhook in your repository (following the instructions here). The config used for the PR job lives in the docs repo in the ./buildkite/pull-requests.org-wide.json file. There should not be any conflicts with your current jobs, but I like to be overly explicit with it.
4. What to expect once this is setup?
The Buildkite PR jobs are non-blocking at this time - but we need your help validating that they produce the same results than in Jenkins - see comm.
The below options are supported to trigger the docs builds: