Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Recommend stack Elasticsearch Python client #242

Merged
merged 2 commits into from
Dec 12, 2024

Conversation

pquentin
Copy link
Member

Relates #241. There's a Python Elasticsearch serverless client (https://github.com/elastic/elasticsearch-serverless-python), but we're planning to deprecate it.

@pquentin pquentin requested a review from a team as a code owner December 12, 2024 09:59
Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

leemthompo
leemthompo previously approved these changes Dec 12, 2024
Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@leemthompo
Copy link
Contributor

@pquentin sorry I approved a little hastily, perhaps we should add an IMPORTANT note for users who happen to use the existing serverless client that we recommend using the classic client?

@pquentin
Copy link
Member Author

We could, however there's near-zero usage of the serverless client today anyway. I was thinking more about adding a deprecation warning in the client itself.

@leemthompo
Copy link
Contributor

We could, however there's near-zero usage of the serverless client today anyway. I was thinking more about adding a deprecation warning in the client itself.

OK that sounds reasonable! In that case should we update the title of this page to remove serverless mention?

Get started with the serverless Python client

@pquentin
Copy link
Member Author

Oops, definitely! Thanks, fixed it.

Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@leemthompo leemthompo merged commit ce304c9 into main Dec 12, 2024
2 checks passed
@leemthompo leemthompo deleted the recommend-stack-python-client branch December 12, 2024 12:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants