-
Notifications
You must be signed in to change notification settings - Fork 20
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Recommend stack Elasticsearch Python client #242
Conversation
A documentation preview will be available soon. Request a new doc build by commenting
If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
@pquentin sorry I approved a little hastily, perhaps we should add an IMPORTANT note for users who happen to use the existing serverless client that we recommend using the classic client? |
We could, however there's near-zero usage of the serverless client today anyway. I was thinking more about adding a deprecation warning in the client itself. |
OK that sounds reasonable! In that case should we update the title of this page to remove serverless mention?
|
Oops, definitely! Thanks, fixed it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Relates #241. There's a Python Elasticsearch serverless client (https://github.com/elastic/elasticsearch-serverless-python), but we're planning to deprecate it.