Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

removing preview tag #210

Merged
merged 5 commits into from
Nov 21, 2024
Merged

removing preview tag #210

merged 5 commits into from
Nov 21, 2024

Conversation

georgewallace
Copy link
Contributor

No description provided.

@github-actions GitHub Actions
Copy link

A documentation preview will be available soon.

Request a new doc build by commenting
  • Rebuild this PR: run docs-build
  • Rebuild this PR and all Elastic docs: run docs-build rebuild

run docs-build is much faster than run docs-build rebuild. A rebuild should only be needed in rare situations.

If your PR continues to fail for an unknown reason, the doc build pipeline may be broken. Elastic employees can check the pipeline status here.

@georgewallace georgewallace marked this pull request as ready for review November 20, 2024 21:36
@georgewallace georgewallace requested a review from a team as a code owner November 20, 2024 21:36
kilfoyle
kilfoyle previously approved these changes Nov 20, 2024
View reviewed changes
Copy link
Contributor

@kilfoyle kilfoyle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 🚀

@georgewallace
Copy link
Contributor Author

@elasticmachine update branch

@georgewallace
Copy link
Contributor Author

run docs-build

lcawl
lcawl approved these changes Nov 21, 2024
View reviewed changes
Copy link
Contributor

@lcawl lcawl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@georgewallace georgewallace merged commit 8bdf0a7 into elastic:main Nov 21, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lcawl lcawl lcawl approved these changes

@kilfoyle kilfoyle kilfoyle left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@georgewallace @lcawl @kilfoyle