Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade helm to v3.14.2 #2356

Merged
merged 9 commits into from
Jul 28, 2024
Merged

Conversation

jeniawhite
Copy link
Contributor

@jeniawhite jeniawhite commented Jul 28, 2024

Summary of your changes

In order to handle CVE-2024-26147, we are required to bump helm version.
Decided to remove the PSP fetching (left the rules) in order to bump the helm, elastic-agent-autodiscover, k8s apis.
After this PR we should handle the PSP case scenario correctly and deliver a hotfix (backport) in order to support it fully.

Related Issues

Related:

Checklist

  • I have added tests that prove my fix is effective or that my feature works
  • I have added the necessary README/documentation (if appropriate)

Introducing a new rule?

@jeniawhite jeniawhite requested a review from a team as a code owner July 28, 2024 09:25
Copy link

mergify bot commented Jul 28, 2024

This pull request does not have a backport label. Could you fix it @jeniawhite? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 8./d branch. /d is the digit
    NOTE: backport-skip has been added to this pull request.

Copy link

github-actions bot commented Jul 28, 2024

📊 Allure Report - 💚 No failures were reported.

Result Count
🟥 Failed 0
🟩 Passed 359
⬜ Skipped 33

Copy link
Collaborator

@gurevichdmitry gurevichdmitry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI, manifests, and tests are LGTM.

Copy link
Contributor

@uri-weisman uri-weisman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

Note: Existing customers with PSPs in their cluster will notice a change in their posture score because those findings will no longer be evaluated.

@jeniawhite jeniawhite merged commit 0029a1a into elastic:main Jul 28, 2024
24 checks passed
mergify bot pushed a commit that referenced this pull request Jul 28, 2024
* Bump helm

* Disable PSP feature leave rules

* Bumping elastic-agent-autodiscover

* Lint fixes

* Linter empty space

* Commenting out CI tests and removing codeblocks from core code

* Comment out EKS PSP

* Remove imports from CI tests

* Update rules coverage

(cherry picked from commit 0029a1a)

# Conflicts:
#	go.mod
#	go.sum
jeniawhite added a commit that referenced this pull request Jul 28, 2024
* Upgrade helm to v3.14.2 (#2356)

* Bump helm

* Disable PSP feature leave rules

* Bumping elastic-agent-autodiscover

* Lint fixes

* Linter empty space

* Commenting out CI tests and removing codeblocks from core code

* Comment out EKS PSP

* Remove imports from CI tests

* Update rules coverage

(cherry picked from commit 0029a1a)

# Conflicts:
#	go.mod
#	go.sum

* Conflicts resolve

* Fixing tidy

---------

Co-authored-by: Evgeniy Belyi <[email protected]>
Copy link
Member

@romulets romulets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

mergify bot pushed a commit that referenced this pull request Aug 20, 2024
* Bump helm

* Disable PSP feature leave rules

* Bumping elastic-agent-autodiscover

* Lint fixes

* Linter empty space

* Commenting out CI tests and removing codeblocks from core code

* Comment out EKS PSP

* Remove imports from CI tests

* Update rules coverage

(cherry picked from commit 0029a1a)

# Conflicts:
#	.github/workflows/ci.yml
#	go.mod
#	go.sum
#	resources/fetching/fetchers/k8s/kube_fetcher_test.go
#	resources/fetching/fetchers/k8s/kube_provider.go
#	security-policies/RULES.md
#	tests/product/tests/data/k8s/k8s_object_cases.py
#	tests/product/tests/data/k8s_object/eks_k8s_object_test_cases.py
#	tests/test_environments/k8s-objects-all-cases.yml
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants