Do not expect deletion if data migration is in progress #474
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sebgl
approved these changes
Mar 6, 2019
| // do not delete a pod or expect a deletion if a data migration is in progress | ||
| isMigratingData := migration.IsMigratingData(observedState, pod, ToDelete) | ||
| if isMigratingData { | ||
| log.Info("Skipping deletes because of migrating data", "pod", pod.Name) |
There was a problem hiding this comment.
Nit: I know it doesn't come from your PR, but maybe we could change Skipping deletes to Skipping deletion?
thbkrkr
approved these changes
Mar 6, 2019
|
|
||
| // deletePods deletes a list of pods after checking there is no migrating data for each of them | ||
| func (d *defaultDriver) deletePods( | ||
| ToDelete []corev1.Pod, |
There was a problem hiding this comment.
I would tend to keep the variable name in lowercase: toDelete.
barkbay
deleted the
fix-469-Do-not-expect-deletion-if-data-migration-is-in-progress
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #469