Don't upgrade pods if empty StatefulSet UpdateRevision (#2321) #2336
+25
−15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We had a bug were some Pods of a newly created StatefulSet would be force upgraded because they are Pending, and we consider they need to be upgraded because their revision does not match the StatefulSet update revision. That's because the StatefulSet updateRevision is empty on initial StatefulSet creation. This commit fixes it by not considering empty StatefulSet updateRevisions when looking for Pods to upgrade.
sebgl
approved these changes
Jan 3, 2020
|
jenkins test this please |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #2321 in 1.0