Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle authorization errors in Kafka output #42401

Merged
merged 2 commits into from
Jan 23, 2025

Conversation

belimawr
Copy link
Contributor

@belimawr belimawr commented Jan 22, 2025

Proposed commit message

When there is an authorisation error in the Kafka output, the events are dropped and an error message is logged.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

## Disruptive User Impact
## Author's Checklist

How to test this PR locally

Run the tests added by this PR:

mage buildSystemTestBinary
go test -tags integration -run=TestAuthorisationErrors -v ./tests/integration

If you want to run any Beat yourself, you can modify the test so it only starts the mock and waits, then configure a Beat to connect to it.

Related issues

## Use cases
## Screenshots
## Logs

@belimawr belimawr requested a review from a team as a code owner January 22, 2025 18:41
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jan 22, 2025
@belimawr belimawr force-pushed the 42343-kafka-handle-auth-error branch from b11da27 to a5fe2e6 Compare January 22, 2025 18:42
Copy link
Contributor

mergify bot commented Jan 22, 2025

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b 42343-kafka-handle-auth-error upstream/42343-kafka-handle-auth-error
git merge upstream/main
git push upstream 42343-kafka-handle-auth-error

Copy link
Contributor

mergify bot commented Jan 22, 2025

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @belimawr? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-8./d is the label to automatically backport to the 8./d branch. /d is the digit

Copy link
Contributor

mergify bot commented Jan 22, 2025

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Jan 22, 2025
When there is an authorisation error in the Kafka output, the events
are dropped and an error message is logged.
@belimawr belimawr force-pushed the 42343-kafka-handle-auth-error branch from a5fe2e6 to d1e1755 Compare January 22, 2025 18:43
@belimawr belimawr added the Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team label Jan 22, 2025
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jan 22, 2025
@belimawr belimawr requested a review from mauri870 January 22, 2025 21:21
@mauri870 mauri870 changed the title Handle authorisation errors in Kafka output Handle authorization errors in Kafka output Jan 22, 2025
@belimawr belimawr merged commit 5720300 into elastic:main Jan 23, 2025
142 checks passed
mergify bot pushed a commit that referenced this pull request Jan 23, 2025
When there is an authorisation error in the Kafka output, the events
are dropped and an error message is logged.

(cherry picked from commit 5720300)
belimawr added a commit that referenced this pull request Jan 23, 2025
When there is an authorisation error in the Kafka output, the events
are dropped and an error message is logged.

(cherry picked from commit 5720300)

Co-authored-by: Tiago Queiroz <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Kafka output causes high CPU usage when ACL is missconfigured
4 participants