Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x](backport #42391) CI: x-pack/packetbeat: Enable GCP authentication for system tests #42393

Open
wants to merge 2 commits into
base: 8.x
Choose a base branch
from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jan 22, 2025

Proposed commit message

Enable GCP authentication for packetbeat windows system tests. Relates to Marc's PR

Extracted gcp_auth.sh from pre-command hook for simplicity
Ran the pipeline directly for this branch. The npcap is being successfully downloaded. Some follow-up work is expected

CC @marc-gr @oakrizan

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs


This is an automatic backport of pull request #42391 done by [Mergify](https://mergify.com).

…2391)

* CI: x-pack/packetbeat: Enable GCP authentication for system tests

* Made gcp_auth.sh executable

(cherry picked from commit 5bd76b0)

# Conflicts:
#	.buildkite/hooks/pre-command
@mergify mergify bot requested a review from a team as a code owner January 22, 2025 14:13
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Jan 22, 2025
@mergify mergify bot assigned pazone Jan 22, 2025
Copy link
Contributor Author

mergify bot commented Jan 22, 2025

Cherry-pick of 5bd76b0 has failed:

On branch mergify/bp/8.x/pr-42391
Your branch is up to date with 'origin/8.x'.

You are currently cherry-picking commit 5bd76b0d5.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	new file:   .buildkite/scripts/gcp_auth.sh
	modified:   .buildkite/x-pack/pipeline.xpack.packetbeat.yml

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   .buildkite/hooks/pre-command

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jan 22, 2025
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jan 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport conflicts There is a conflict in the backported pull request enhancement Team:Ingest-EngProd
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant