Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.x](backport #41918) Let network processor handle multiple IPs #41958

Merged
merged 2 commits into from
Dec 16, 2024
Merged

[8.x](backport #41918) Let network processor handle multiple IPs #41958

merged 2 commits into from
Dec 16, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 9, 2024

Proposed commit message

This fixes a bug where the network processor would simply fail if it was given a document that had a list of IPs instead of a single IP. This uses "any match is a match" logic and instead traverses the list of IPs, if there is one.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Issue

#41917

This is an automatic backport of pull request #41918 done by Mergify.

@fearful-symmetry @mergify
Let network processor handle multiple IPs (#41918)
34bb9ac 
* let network processor handle multiple IPs

* add changelog

* linter...

* fix linter, logs, changelog

* linter...

* linter...

* linter...

* update docs

* whoops

* simplify logic

* docs, cleanup

(cherry picked from commit 0827467)
@mergify mergify bot requested a review from a team as a code owner December 9, 2024 15:33
@mergify mergify bot added the backport label Dec 9, 2024
@mergify mergify bot requested review from belimawr and mauri870 and removed request for a team December 9, 2024 15:33
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 9, 2024
@botelastic
Copy link

botelastic bot commented Dec 9, 2024

This pull request doesn't have a Team:<team> label.

@mergify Mergify
Copy link
Contributor Author

mergify bot commented Dec 9, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b mergify/bp/8.x/pr-41918 upstream/mergify/bp/8.x/pr-41918
git merge upstream/8.x
git push upstream mergify/bp/8.x/pr-41918

@mergify Mergify
Copy link
Contributor Author

mergify bot commented Dec 16, 2024

This pull request has not been merged yet. Could you please review and merge it @fearful-symmetry? 🙏

@fearful-symmetry fearful-symmetry merged commit 1b9d2d6 into 8.x Dec 16, 2024
142 checks passed
@fearful-symmetry fearful-symmetry deleted the mergify/bp/8.x/pr-41918 branch December 16, 2024 17:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@belimawr belimawr Awaiting requested review from belimawr belimawr is a code owner automatically assigned from elastic/elastic-agent-data-plane

@mauri870 mauri870 Awaiting requested review from mauri870 mauri870 is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees

@fearful-symmetry fearful-symmetry

Labels
backport needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fearful-symmetry