Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x](backport #41816) move metricbeat command setup out of init #41854

Merged
merged 1 commit into from
Dec 2, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Dec 2, 2024

Proposed commit message

Move metricbeat command setup outside of init function. Having the setup inside the init function causes problems when you import metricbeat into other code bases. A specific use case is when you use metricbeat as an otel receiver.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

None.

Author's Checklist

  • [ ]

How to test this PR locally

Run unit tests

Related issues

Use cases

Screenshots

Logs


This is an automatic backport of pull request #41816 done by [Mergify](https://mergify.com).

@mergify mergify bot added the backport label Dec 2, 2024
@mergify mergify bot requested a review from a team as a code owner December 2, 2024 14:48
@mergify mergify bot requested review from rdner and VihasMakwana and removed request for a team December 2, 2024 14:48
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Dec 2, 2024
@botelastic
Copy link

botelastic bot commented Dec 2, 2024

This pull request doesn't have a Team:<team> label.

@leehinman leehinman merged commit 97c25f6 into 8.x Dec 2, 2024
79 checks passed
@leehinman leehinman deleted the mergify/bp/8.x/pr-41816 branch December 2, 2024 16:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant