-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[filebeat] Introduce otel mode #41849
Conversation
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
|
Overall looks good. Just need to address lint failures and handle errors. |
Co-authored-by: Vihas Makwana <[email protected]>
Co-authored-by: Mauri de Souza Meneguzzo <[email protected]>
Co-authored-by: Mauri de Souza Meneguzzo <[email protected]>
Co-authored-by: Denis <[email protected]>
This pull request is now in conflicts. Could you fix it? 🙏
|
so we cannot use And it works correctly now with this cmd
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Current state looks good to me.
I expect all the TODOs to be addressed in a follow up PR right after merging this.
/test |
@khushijain21 looks like you got enough approvals to move this over the line right? |
This pull request is now in conflicts. Could you fix it? 🙏
|
/test |
- Introduce otel mode for filebeat --------- Co-authored-by: Vihas Makwana <[email protected]> Co-authored-by: Mauri de Souza Meneguzzo <[email protected]> Co-authored-by: Denis <[email protected]> (cherry picked from commit a306a4e) # Conflicts: # NOTICE.txt # go.mod # go.sum
- Introduce otel mode for filebeat --------- Co-authored-by: Vihas Makwana <[email protected]> Co-authored-by: Mauri de Souza Meneguzzo <[email protected]> Co-authored-by: Denis <[email protected]> (cherry picked from commit a306a4e) Co-authored-by: Khushi Jain <[email protected]>
To note
libbeat/otelbeat/
libbeat/outputs/${output_type}
elasticsearch
is configuredElasticsearch paramaters that are currently unsupported
and some TLS paramaters that are currently not supported
The change in filebeat and agentbeat binary sizes before and after this changeset is as follows
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.How to test this PR locally
Elasticsearch ouput was tested manually. The following are the steps
Run
Add following config to filebeat-otel.yml in
x-pack/filebeat/
Add dummy text to
test.log
and you can verify they are reaching kibana onlocalhost:5601
It was also manually tested with elasticsearch service