Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.x](backport #41542) Switch to base 16 for TLS serial number in packetbeat in line with ECS changes #41693

Merged
merged 5 commits into from
Nov 25, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Nov 19, 2024

Proposed commit message

This switches the serial_number field in packetbeat's TLS reporting to use base 16 values instead of base 10:

		"public_key_size":             "2048",
		"serial_number":               "1121E97D5D37348C572C555A3A59B7B65D2B",
		"signature_algorithm":         "SHA256-RSA",

I don't think this is a breaking change? Also note the lack of a 0x indicator. Not sure if we care.

ECS PR here: elastic/ecs#2383

Also note that this maintains the liter bypass for dsa, which is deprecated. Do we still need it?

Checklist

  • My code follows the style guidelines of this project
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Disruptive User Impact

This will alter the reported serial_number for TLS certs from base 10 to base 16.


This is an automatic backport of pull request #41542 done by [Mergify](https://mergify.com).

…S changes (#41542)

* switch to base 16 for cert serial  number

* uppercase

* linter...

* clean up test

* try to fix integration tests

* add changelog

* update readme

(cherry picked from commit 38b2d66)
@mergify mergify bot added the backport label Nov 19, 2024
@mergify mergify bot requested a review from a team as a code owner November 19, 2024 20:57
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Nov 19, 2024
@botelastic
Copy link

botelastic bot commented Nov 19, 2024

This pull request doesn't have a Team:<team> label.

Copy link
Contributor Author

mergify bot commented Nov 21, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b mergify/bp/8.x/pr-41542 upstream/mergify/bp/8.x/pr-41542
git merge upstream/8.x
git push upstream mergify/bp/8.x/pr-41542

Copy link
Contributor Author

mergify bot commented Nov 25, 2024

This pull request has not been merged yet. Could you please review and merge it @fearful-symmetry? 🙏

@fearful-symmetry fearful-symmetry merged commit 28f87a7 into 8.x Nov 25, 2024
30 checks passed
@fearful-symmetry fearful-symmetry deleted the mergify/bp/8.x/pr-41542 branch November 25, 2024 21:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants