Update shared-instrumentation.asciidoc #39805
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Not sure what are our guide lines regarding `warning` and `note` but I believe this part of the documentation might be interesting to highlight.
redcinelli
requested review from
belimawr and
fearful-symmetry
and removed request for
a team
botelastic
bot
added
the
needs_team
belimawr
reviewed
Jun 5, 2024
| To gain insight into the performance of {beatname_uc}, you can enable this instrumentation and send trace data to the APM Integration. | ||
|
|
||
| WARNING: Currently, only the Elasticsearch output is instrumented. |
There was a problem hiding this comment.
Because this is not going to break the data ingestion/behaviour of Beats, I'd go with note instead of warning. Looking at the Filestream documentation, warning is used for things that will lead to a broken configuraiton/state.
pierrehilbert
added
the
Team:Elastic-Agent-Data-Plane
|
Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane) |
botelastic
bot
removed
the
needs_team
|
@redcinelli Did you get time to look at @belimawr's comment? |
|
Sending back to draft for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not sure what are our guide lines regarding
warningandnotebut I believe this part of the documentation might be interesting to highlight.