Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[8.13](backport #38964) migrate x-pack/libbeat to static #39083

Merged
merged 6 commits into from
Apr 22, 2024
Merged

[8.13](backport #38964) migrate x-pack/libbeat to static #39083

merged 6 commits into from
Apr 22, 2024

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Apr 19, 2024

What is the problem this PR solves?

Jenkins->Buildkite pipelines migration

Migrate x-pack/libbeat from dynamic to static pipeline

Examples of the pipelines:
https://buildkite.com/elastic/beats/builds/5828
https://buildkite.com/elastic/beats-xpack-libbeat/builds/2673

Related issues

https://github.com/elastic/ingest-dev/issues/1693

This is an automatic backport of pull request #38964 done by [Mergify](https://mergify.com).

@sharbuz @mergify
migrate x-pack/libbeat to static (#38964)
49a3e41 
* migrate x-pack/libbeat to static

* Update pull-requests.json

* change paths

* Update pull-requests.json

* change conditions for group-steps

* change the pipeline.yml

* work with remarks

* work with remarks

* remove libbeat and x-pack/libbeat changesets from the common.sh

* remove libbeat and x-pack/libbeat changesets from the common.sh

* fix merge issues

* Update .buildkite/x-pack/pipeline.xpack.libbeat.yml

Co-authored-by: Dimitrios Liappis <[email protected]>

* apply common.sh from main and cleanup it

* change paths

---------

Co-authored-by: Dimitrios Liappis <[email protected]>
(cherry picked from commit b0690b5)

# Conflicts:
#	.buildkite/pipeline.yml
#	.buildkite/pull-requests.json
#	.buildkite/scripts/common.sh
@mergify mergify bot requested a review from a team as a code owner April 19, 2024 15:03
@mergify mergify bot added backport conflicts There is a conflict in the backported pull request labels Apr 19, 2024
@mergify Mergify
Copy link
Contributor Author

mergify bot commented Apr 19, 2024

Cherry-pick of b0690b5 has failed:

On branch mergify/bp/8.13/pr-38964
Your branch is up to date with 'origin/8.13'.

You are currently cherry-picking commit b0690b5fb9.
  (fix conflicts and run "git cherry-pick --continue")
  (use "git cherry-pick --skip" to skip this patch)
  (use "git cherry-pick --abort" to cancel the cherry-pick operation)

Changes to be committed:
	modified:   .buildkite/hooks/pre-command
	deleted:    .buildkite/scripts/generate_xpack_libbeat_pipeline.sh
	modified:   .buildkite/x-pack/pipeline.xpack.libbeat.yml

Unmerged paths:
  (use "git add <file>..." to mark resolution)
	both modified:   .buildkite/pipeline.yml
	both modified:   .buildkite/pull-requests.json
	both modified:   .buildkite/scripts/common.sh

To fix up this pull request, you can check it out locally. See documentation: https://docs.github.com/en/pull-requests/collaborating-with-pull-requests/reviewing-changes-in-pull-requests/checking-out-pull-requests-locally

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Apr 19, 2024
@botelastic
Copy link

botelastic bot commented Apr 19, 2024

This pull request doesn't have a Team:<team> label.

@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 19, 2024 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 13 min 38 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@sharbuz sharbuz added the arm Enable builds in the CI for ARM testing label Apr 19, 2024
@sharbuz sharbuz requested review from dliappis and alexsapran April 19, 2024 16:03
dliappis
dliappis approved these changes Apr 19, 2024
View reviewed changes
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergify Mergify
Copy link
Contributor Author

mergify bot commented Apr 22, 2024

This pull request has not been merged yet. Could you please review and merge it @sharbuz? 🙏

@sharbuz sharbuz merged commit fdae792 into 8.13 Apr 22, 2024
94 checks passed
@sharbuz sharbuz deleted the mergify/bp/8.13/pr-38964 branch April 22, 2024 08:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dliappis dliappis dliappis approved these changes

@alexsapran alexsapran Awaiting requested review from alexsapran

Assignees

@sharbuz sharbuz

Labels
arm Enable builds in the CI for ARM testing backport conflicts There is a conflict in the backported pull request needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@elasticmachine @dliappis @sharbuz