Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgraded go-sysinfo #38778

Closed
wants to merge 6 commits into from
Closed

Conversation

kaanyalti
Copy link
Contributor

@kaanyalti kaanyalti commented Apr 9, 2024

  • Enhancement

Proposed commit message

Upgrades go-sysinfo package

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@kaanyalti kaanyalti requested a review from a team as a code owner April 9, 2024 06:11
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Apr 9, 2024
Copy link
Contributor

mergify bot commented Apr 9, 2024

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @kaanyalti? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@elasticmachine
Copy link
Collaborator

elasticmachine commented Apr 9, 2024

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 147 min 45 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@pierrehilbert pierrehilbert added the Team:Elastic-Agent Label for the Agent team label Apr 9, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Apr 9, 2024
@kaanyalti kaanyalti changed the title upgrdaed go-sysinfo upgraded go-sysinfo Apr 9, 2024
@kaanyalti kaanyalti force-pushed the upgrade-go-sysinfo branch from 53ea293 to b8083b7 Compare April 9, 2024 16:25
@kaanyalti kaanyalti force-pushed the upgrade-go-sysinfo branch from b8083b7 to de6b1fb Compare April 10, 2024 06:27
Copy link
Contributor

mergify bot commented Apr 15, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b upgrade-go-sysinfo upstream/upgrade-go-sysinfo
git merge upstream/main
git push upstream upgrade-go-sysinfo

@kaanyalti kaanyalti force-pushed the upgrade-go-sysinfo branch 2 times, most recently from 4d8714f to fc06fd6 Compare April 15, 2024 20:39
Copy link
Contributor

mergify bot commented Apr 16, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b upgrade-go-sysinfo upstream/upgrade-go-sysinfo
git merge upstream/main
git push upstream upgrade-go-sysinfo

@kaanyalti kaanyalti force-pushed the upgrade-go-sysinfo branch from fc06fd6 to b0a604a Compare April 16, 2024 14:33
Copy link
Contributor

mergify bot commented Dec 26, 2024

backport-8.x has been added to help with the transition to the new branch 8.x.
If you don't need it please use backport-skip label and remove the backport-8.x label.

@mergify mergify bot added the backport-8.x Automated backport to the 8.x branch with mergify label Dec 26, 2024
Copy link
Contributor

mergify bot commented Dec 26, 2024

This pull request is now in conflicts. Could you fix it? 🙏
To fixup this pull request, you can check out it locally. See documentation: https://help.github.com/articles/checking-out-pull-requests-locally/

git fetch upstream
git checkout -b upgrade-go-sysinfo upstream/upgrade-go-sysinfo
git merge upstream/main
git push upstream upgrade-go-sysinfo

@jlind23
Copy link
Collaborator

jlind23 commented Dec 30, 2024

Closing this as outdated as main is already relying on go-sysinfo v1.15.0

@jlind23 jlind23 closed this Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-8.x Automated backport to the 8.x branch with mergify Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants