Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Elastic agent core publishing #38447

Merged
merged 54 commits into from
Mar 25, 2024
Merged

Elastic agent core publishing #38447

merged 54 commits into from
Mar 25, 2024

Conversation

pazone
Copy link
Contributor

@pazone pazone commented Mar 19, 2024 •
edited
Loading

Proposed commit message

Elastic agent core packaging and publishing pipeline. Uploads elastic agent core without dependencies to DRA on demand or by a schedule.

Synchronised packaging target with 8.x.
Added darwin-arm64 to default packaging targets
Added core packaging pipeline

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • Pipeline successfully uploads the required artifacts
  • E2e tests are passing

How to test this PR locally

Related issues

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 19, 2024
@mergify mergify bot assigned pazone Mar 19, 2024
@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 19, 2024 •
edited
Loading

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Duration: 126 min 48 sec

Pipeline error 1

This error is likely related to the pipeline itself. Click here
and then you will see the error (either incorrect syntax or an invalid configuration).

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@pazone pazone marked this pull request as ready for review March 20, 2024 18:56
@pazone pazone requested review from a team as code owners March 20, 2024 18:56
@pazone pazone requested review from AndersonQ, pchila, fearful-symmetry and faec and removed request for a team March 20, 2024 18:56
DaveSys911
DaveSys911 approved these changes Mar 20, 2024
View reviewed changes
Copy link

@DaveSys911 DaveSys911 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 22, 2024 •
edited
Loading

💔 Build Failed

Failed CI Steps

History

cc @pazone

@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 22, 2024 •
edited
Loading

💔 Build Failed

Failed CI Steps

History

cc @pazone

@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 22, 2024 •
edited
Loading

💔 Build Failed

Failed CI Steps

History

cc @pazone

@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 22, 2024 •
edited
Loading

💔 Build Failed

Failed CI Steps

History

cc @pazone

@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 22, 2024 •
edited
Loading

💔 Build Failed

Failed CI Steps

History

cc @pazone

@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 22, 2024 •
edited
Loading

💔 Build Failed

Failed CI Steps

History

cc @pazone

@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 22, 2024 •
edited
Loading

💔 Build Failed

Failed CI Steps

History

cc @pazone

@elasticmachine
Copy link
Collaborator

💔 Build Failed

Failed CI Steps

History

cc @pazone

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @pazone

v1v
v1v reviewed Mar 22, 2024
View reviewed changes
dev-tools/mage/platforms.go Outdated
@@ -33,7 +33,7 @@ var BuildPlatforms = BuildPlatformList{
{"darwin/386", CGOSupported | CrossBuildSupported},
{"darwin/amd64", CGOSupported | CrossBuildSupported | Default},
{"darwin/arm", CGOSupported},
{"darwin/arm64", CGOSupported},
{"darwin/arm64", CGOSupported | CrossBuildSupported | Default},
Copy link
Member

@v1v v1v Mar 22, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the reason for the failure of the build

[2024-03-22T13:47:27.230Z] Digest: sha256:36dd07b8e4d109af2f2865d347cbe2e1560cd8d63b9778d0e97daa2554853fc0
[2024-03-22T13:47:27.230Z] Status: Downloaded newer image for docker.elastic.co/beats-dev/golang-crossbuild:1.21.8-darwin-arm64-debian10
[2024-03-22T13:47:31.152Z] >> Building using: cmd='build/mage-linux-amd64 golangCrossBuild', env=[CC=oa64-clang, CXX=oa64-clang++, GOARCH=arm64, GOARM=, GOOS=darwin, PLATFORM_ID=darwin-arm64]
[2024-03-22T13:49:33.794Z] # github.com/shirou/gopsutil/cpu
[2024-03-22T13:49:33.794Z] /go/pkg/mod/github.com/shirou/[email protected]+incompatible/cpu/cpu_darwin_cgo.go:13:5: error: 'TARGET_OS_MAC' is not defined, evaluates to 0 [-Werror,-Wundef-prefix=TARGET_OS_]
[2024-03-22T13:49:33.794Z] #if TARGET_OS_MAC
[2024-03-22T13:49:33.794Z]     ^
[2024-03-22T13:49:33.794Z] 1 error generated.

@pazone
Copy link
Contributor Author

pazone commented Mar 22, 2024 •
edited
Loading

Blocked by https://github.com/elastic/infra/pull/40818

@pierrehilbert pierrehilbert added the Team:Elastic-Agent Label for the Agent team label Mar 23, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Mar 23, 2024
@DaveSys911
Copy link

Blocked by elastic/infra#40818

Approved & queued for merge

@jlind23 jlind23 disabled auto-merge March 25, 2024 09:29
@jlind23 jlind23 merged commit 96fcf35 into 7.17 Mar 25, 2024
24 of 40 checks passed
@jlind23 jlind23 deleted the xpack_agent_core_publish branch March 25, 2024 09:29
@cmacknz
Copy link
Member

cmacknz commented Mar 25, 2024

This is a late comment, but elastic-agent-core isn't used in 7.17, it exists purely to support the independent agent releases project which we aren't planning to support in 7.17.

The mage package target doesn't consume this artifact at all anywhere right now, the elastic-agent repository will only begin to use it once elastic/elastic-agent#4403 is merged.

v1v
v1v reviewed Mar 25, 2024
View reviewed changes
.buildkite/x-pack/elastic-agent/.buildkite/pipeline.xpack.elastic-agent-binary-dra.yml
@@ -0,0 +1,85 @@
# yaml-language-server: $schema=https://raw.githubusercontent.com/buildkite/pipeline-schema/main/schema.json
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's the reason for using this path that contains .buildkite twice (parent and sibling)? As far as I see, there are already pipelines in the folder .buildkite/x-pack/elastic-agent:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v1v v1v v1v left review comments

@pchila pchila pchila approved these changes

@DaveSys911 DaveSys911 DaveSys911 approved these changes

@AndersonQ AndersonQ Awaiting requested review from AndersonQ AndersonQ is a code owner automatically assigned from elastic/elastic-agent-control-plane

@fearful-symmetry fearful-symmetry Awaiting requested review from fearful-symmetry fearful-symmetry is a code owner automatically assigned from elastic/elastic-agent-data-plane

@faec faec Awaiting requested review from faec faec is a code owner automatically assigned from elastic/elastic-agent-data-plane

@pierrehilbert pierrehilbert Awaiting requested review from pierrehilbert

Assignees

@pazone pazone

Labels
enhancement Team:Elastic-Agent Label for the Agent team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@pazone @elasticmachine @DaveSys911 @cmacknz @v1v @pchila @pierrehilbert @jlind23