-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
buildkite: change github comments #38173
Conversation
This pull request doesn't have a |
This pull request does not have a backport label.
To fixup this pull request, you need to add the backport labels for the needed
|
💚 Build Succeeded
cc @v1v |
💚 Build Succeeded
cc @v1v |
💚 Build Succeeded
cc @v1v |
💚 Build Succeeded
cc @v1v |
💚 Build Succeeded
cc @v1v |
💚 Build Succeeded
cc @v1v |
@alexsapran This older open PR looks very similar to your fix from #38487 |
Indeed, #38487 might have some side effects while Jenkins is still the CI. This PR was intended to leverage the existing proposal in #38162 without running twice (builds in Jenkins and Buildkite) during the migration. That's the reason I used the |
What type of side effects you are thinking of? other than the fact that it will trigger both? It's something that I wanted to have, so I can test that both implementations are doing what we want them to do, this is how I discovered for example an issue with how we select some pipeline steps, by checking the Jenkins and Buildkite steps. |
That's the only thing.
Then forget please what I said, I didn't have that context. Sorry for the noise 🙏 |
I'll close this now as duplicates the other one |
Pull request was closed
Better safe than sorry, thanks for keeping an eye and for asking questions. |
Proposed commit message
Checklist
CHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
How to test this PR locally
I used https://regex101.com/ for verifying the regex:
Related issues
Use cases
Screenshots
Logs