Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Heartbeat pipeline migration #37911

Merged
merged 14 commits into from
Feb 8, 2024
Merged

Heartbeat pipeline migration #37911

merged 14 commits into from
Feb 8, 2024

Conversation

oakrizan
Copy link
Contributor

@oakrizan oakrizan commented Feb 7, 2024 •
edited
Loading

Proposed commit message

Migration of heartbeat pipeline to Buildkite
Phase according to migration plan: 1
Phase scope:

  1. Migrate separate Jenkinsfiles/Groovy scripts to Buildkite pipelines with following scope:
  • Execution conditions - only:
  • changeset
  • trigger comments
  1. Agents - migrate those available both Jenkinsfile and those that are available in Buildkite

Link to Bildkite branch builds: https://buildkite.com/elastic/heartbeat/builds?branch=oakrizan%3Aheartbeat-pipeline-migration
Libbeat & metricbeat fixed in #37825

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

Author's Checklist

  • [ ]

How to test this PR locally

Related issues

Use cases

Screenshots

Logs

@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Feb 7, 2024
@oakrizan oakrizan added enhancement backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.12.0 Automated backport with mergify and removed needs_team Indicates that the issue/PR needs a Team:* label labels Feb 7, 2024
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Feb 7, 2024
@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 7, 2024 •
edited
Loading

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2024-02-08T17:45:59.161+0000

  • Duration: 13 min 15 sec

Test stats 🧪

Test Results
Failed 0
Passed 3
Skipped 0
Total 3

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@oakrizan oakrizan force-pushed the heartbeat-pipeline-migration branch 16 times, most recently from 6aaa5d4 to 4832ca8 Compare February 8, 2024 06:36
@oakrizan oakrizan requested review from dliappis and v1v February 8, 2024 06:37
@oakrizan oakrizan added the Team:Elastic-Agent Label for the Agent team label Feb 8, 2024
@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Feb 8, 2024
@oakrizan oakrizan marked this pull request as ready for review February 8, 2024 06:38
@oakrizan oakrizan requested a review from a team as a code owner February 8, 2024 06:38
@oakrizan
Copy link
Contributor Author

oakrizan commented Feb 8, 2024

@dliappis PTAL

v1v
v1v reviewed Feb 8, 2024
View reviewed changes
@oakrizan oakrizan force-pushed the heartbeat-pipeline-migration branch from 65bf398 to c1a4348 Compare February 8, 2024 14:50
dliappis
dliappis approved these changes Feb 8, 2024
View reviewed changes
Copy link
Contributor

@dliappis dliappis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Left a few asks for comments (no need for another review cycle)

@oakrizan oakrizan force-pushed the heartbeat-pipeline-migration branch from aef97ef to a18ea53 Compare February 8, 2024 17:45
@oakrizan oakrizan enabled auto-merge (squash) February 8, 2024 17:45
@oakrizan oakrizan merged commit edba3bc into elastic:main Feb 8, 2024
24 of 33 checks passed
mergify bot pushed a commit that referenced this pull request Feb 8, 2024
@oakrizan @mergify
Heartbeat pipeline migration (#37911)
c826756 
* added heartbeat scripts and updated pipeline

* made scripts executable

* removed gcp agent for skipped packaging step

* added agent name from matrix to GH notifications

* testing dynamic step

* fixed typo

* updated command

* added agent

* testing annotate step

* code cleanup

* restored dynamic step

* updated GH notifictions

* updated GH notifications

* added comments

(cherry picked from commit edba3bc)
mergify bot pushed a commit that referenced this pull request Feb 8, 2024
@oakrizan @mergify
Heartbeat pipeline migration (#37911)
891a3e6 
* added heartbeat scripts and updated pipeline

* made scripts executable

* removed gcp agent for skipped packaging step

* added agent name from matrix to GH notifications

* testing dynamic step

* fixed typo

* updated command

* added agent

* testing annotate step

* code cleanup

* restored dynamic step

* updated GH notifictions

* updated GH notifications

* added comments

(cherry picked from commit edba3bc)
This was referenced Feb 8, 2024
Merged
Merged
@elasticmachine
Copy link
Collaborator

💔 Build Failed

Failed CI Steps

History

cc @oakrizan

oakrizan added a commit that referenced this pull request Feb 9, 2024
@mergify @oakrizan
Heartbeat pipeline migration (#37911) (#37933)
d1e1ba4 
* added heartbeat scripts and updated pipeline

* made scripts executable

* removed gcp agent for skipped packaging step

* added agent name from matrix to GH notifications

* testing dynamic step

* fixed typo

* updated command

* added agent

* testing annotate step

* code cleanup

* restored dynamic step

* updated GH notifictions

* updated GH notifications

* added comments

(cherry picked from commit edba3bc)

Co-authored-by: Olga Naydyonock <[email protected]>
oakrizan added a commit that referenced this pull request Feb 9, 2024
@mergify @oakrizan
Heartbeat pipeline migration (#37911) (#37934)
a01499e 
* added heartbeat scripts and updated pipeline

* made scripts executable

* removed gcp agent for skipped packaging step

* added agent name from matrix to GH notifications

* testing dynamic step

* fixed typo

* updated command

* added agent

* testing annotate step

* code cleanup

* restored dynamic step

* updated GH notifictions

* updated GH notifications

* added comments

(cherry picked from commit edba3bc)

Co-authored-by: Olga Naydyonock <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@v1v v1v v1v left review comments

@dliappis dliappis dliappis approved these changes

@jlind23 jlind23 jlind23 approved these changes

@fearful-symmetry fearful-symmetry Awaiting requested review from fearful-symmetry fearful-symmetry was automatically assigned from elastic/elastic-agent-data-plane

@leehinman leehinman Awaiting requested review from leehinman leehinman was automatically assigned from elastic/elastic-agent-data-plane

Assignees

@oakrizan oakrizan

Labels
backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.12.0 Automated backport with mergify enhancement Team:Elastic-Agent Label for the Agent team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@oakrizan @elasticmachine @dliappis @v1v @jlind23