Disable Go Workspaces when executing 'go list' in packaging process #37579

AndersonQ · 2024-01-08T16:57:33Z

running 'go list' with Go worspaces enabled will report all modules listed on go.work, what would make GetModuleName to fail as it requires 'go list' to return only one module, the agent itself.

Proposed commit message

Disable Go Workspaces when executing 'go list' in packaging process

running 'go list' with Go worspaces enabled will report all modules listed on go.work, what would make GetModuleName to fail as it requires 'go list' to return only one module, the agent itself.

What does this PR do?

Disable Go Workspaces when executing 'go list' in agent packaging process

Why is it important?

Running 'go list' with Go worspaces enabled will report all modules listed on go.work, what would make GetModuleName to fail as it requires 'go list' to return only one module, the agent itself.
Therefore if Go workspaces is enabled, packaging the agent will fail

Checklist

My code follows the style guidelines of this project
I have commented my code, particularly in hard-to-understand areas
~~[ ] I have made corresponding changes to the documentation~~
~~[ ] I have made corresponding change to the default configuration files~~
~~[ ] I have added tests that prove my fix is effective or that my feature works~~
~~[ ] I have added an entry in ./changelog/fragments using the changelog tool~~
~~[ ] I have added an integration test or an E2E test~~

How to test this PR locally

create a Go workspace
add a few modules, e.g. elastic-agent-client, elastic-agent-libs
run mage package
without this change it'll fail

Related issues

N/A

Questions to ask yourself

How are we going to support this in production?
How are we going to measure its adoption?
How are we going to debug this?
What are the metrics I should take care of?
...

running 'go list' with Go worspaces enabled will report all modules listed on go.work, what would make GetModuleName to fail as it requires 'go list' to return only one module, the agent itself.

elasticmachine · 2024-01-08T19:20:40Z

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2024-01-08T16:57:50.777+0000
Duration: 143 min 34 sec

Test stats 🧪

Test	Results
Failed	0
Passed	28760
Skipped	2015
Total	30775

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
/package : Generate the packages and run the E2E tests.
/beats-tester : Run the installation tests with beats-tester.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

elasticmachine · 2024-01-09T12:25:06Z

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Start Time: 2024-01-09T09:39:31.251+0000
Duration: 165 min 19 sec

Test stats 🧪

Test	Results
Failed	0
Passed	28760
Skipped	2015
Total	30775

Steps errors

Expand to view the steps failures

`Building Beats » Beats Packaging » PR-37579`

Took 32 min 55 sec . View more details here
Description: null

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
/package : Generate the packages and run the E2E tests.
/beats-tester : Run the installation tests with beats-tester.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

elasticmachine · 2024-01-10T10:49:00Z

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Duration: 164 min 4 sec

Pipeline error

This error is likely related to the pipeline itself. Click here
and then you will see the error (either incorrect syntax or an invalid configuration).

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
/package : Generate the packages and run the E2E tests.
/beats-tester : Run the installation tests with beats-tester.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

elasticmachine · 2024-01-11T15:57:45Z

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Duration: 163 min 53 sec

Pipeline error

This error is likely related to the pipeline itself. Click here
and then you will see the error (either incorrect syntax or an invalid configuration).

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
/package : Generate the packages and run the E2E tests.
/beats-tester : Run the installation tests with beats-tester.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

rdner · 2024-01-12T17:19:07Z

go.mod

@@ -419,3 +419,5 @@ replace (

 // Exclude this version because the version has an invalid checksum.
 exclude github.com/docker/distribution v2.8.0+incompatible
+
+replace github.com/elastic/elastic-agent-client/v7 => github.com/AndersonQ/elastic-agent-client/v7 v7.0.0-20240109062623-907af5c552fb


Did you leave it on purpose? I don't think it's a good idea.

thanks, my bad

@AndersonQ it seems you haven't pushed the update for this line.

belimawr · 2024-01-15T09:10:56Z

go.mod

@@ -419,3 +419,5 @@ replace (

 // Exclude this version because the version has an invalid checksum.
 exclude github.com/docker/distribution v2.8.0+incompatible
+
+replace github.com/elastic/elastic-agent-client/v7 => github.com/AndersonQ/elastic-agent-client/v7 v7.0.0-20240109062623-907af5c552fb


@AndersonQ it seems you haven't pushed the update for this line.

elasticmachine · 2024-01-15T11:25:19Z

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS

Expand to view the summary

Build stats

Duration: 133 min 38 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

/test : Re-trigger the build.
/package : Generate the packages and run the E2E tests.
/beats-tester : Run the installation tests with beats-tester.
run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

…37579) running 'go list' with Go worspaces enabled will report all modules listed on go.work, what would make GetModuleName to fail as it requires 'go list' to return only one module, the agent itself. (cherry picked from commit d4f5d9f)

…37579) (#37635) running 'go list' with Go worspaces enabled will report all modules listed on go.work, what would make GetModuleName to fail as it requires 'go list' to return only one module, the agent itself. (cherry picked from commit d4f5d9f) Co-authored-by: Anderson Queiroz <[email protected]>

…37579) (#37634) running 'go list' with Go worspaces enabled will report all modules listed on go.work, what would make GetModuleName to fail as it requires 'go list' to return only one module, the agent itself. (cherry picked from commit d4f5d9f) Co-authored-by: Anderson Queiroz <[email protected]>

…lastic#37579) running 'go list' with Go worspaces enabled will report all modules listed on go.work, what would make GetModuleName to fail as it requires 'go list' to return only one module, the agent itself.

Disable Go Workspaces when executing 'go list' in packaging process

26ff466

running 'go list' with Go worspaces enabled will report all modules listed on go.work, what would make GetModuleName to fail as it requires 'go list' to return only one module, the agent itself.

AndersonQ added enhancement release-note:skip The PR should be ignored when processing the changelog Team:Elastic-Agent Label for the Agent team backport-7.17 Automated backport to the 7.17 branch with mergify backport-v8.12.0 Automated backport with mergify labels Jan 8, 2024

AndersonQ self-assigned this Jan 8, 2024

AndersonQ requested a review from a team as a code owner January 8, 2024 16:57

AndersonQ requested review from belimawr and fearful-symmetry January 8, 2024 16:57

botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Jan 8, 2024

AndersonQ enabled auto-merge (squash) January 9, 2024 06:04

update agent client

47ea73b

AndersonQ requested a review from a team as a code owner January 9, 2024 09:39

rdner reviewed Jan 12, 2024

View reviewed changes

remove replace

725d3a7

belimawr requested changes Jan 15, 2024

View reviewed changes

AndersonQ force-pushed the disable-go-workspaces-on-package branch from 90028e5 to 725d3a7 Compare January 15, 2024 09:12

AndersonQ requested review from belimawr and rdner January 15, 2024 09:34

belimawr approved these changes Jan 15, 2024

View reviewed changes

rdner approved these changes Jan 15, 2024

View reviewed changes

AndersonQ merged commit d4f5d9f into elastic:main Jan 15, 2024
86 of 89 checks passed

mergify bot mentioned this pull request Jan 15, 2024

[7.17](backport #37579) Disable Go Workspaces when executing 'go list' in packaging process #37634

Merged

mergify bot mentioned this pull request Jan 15, 2024

[8.12](backport #37579) Disable Go Workspaces when executing 'go list' in packaging process #37635

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Disable Go Workspaces when executing 'go list' in packaging process #37579

Disable Go Workspaces when executing 'go list' in packaging process #37579

AndersonQ commented Jan 8, 2024

elasticmachine commented Jan 8, 2024

Build stats

Test stats 🧪

elasticmachine commented Jan 9, 2024

Build stats

Test stats 🧪

`Building Beats » Beats Packaging » PR-37579`

elasticmachine commented Jan 10, 2024

Build stats

elasticmachine commented Jan 11, 2024

Build stats

rdner Jan 12, 2024

AndersonQ Jan 12, 2024

belimawr Jan 15, 2024

AndersonQ Jan 15, 2024

belimawr Jan 15, 2024

elasticmachine commented Jan 15, 2024

Build stats

Disable Go Workspaces when executing 'go list' in packaging process #37579

Disable Go Workspaces when executing 'go list' in packaging process #37579

Conversation

AndersonQ commented Jan 8, 2024

Proposed commit message

What does this PR do?

Why is it important?

Checklist

How to test this PR locally

Related issues

Questions to ask yourself

elasticmachine commented Jan 8, 2024

💚 Build Succeeded

Build stats

Test stats 🧪

💚 Flaky test report

🤖 GitHub comments

elasticmachine commented Jan 9, 2024

💔 Build Failed

Build stats

Test stats 🧪

Steps errors

Building Beats » Beats Packaging » PR-37579

💚 Flaky test report

🤖 GitHub comments

elasticmachine commented Jan 10, 2024

💔 Build Failed

Build stats

Pipeline error

❕ Flaky test report

🤖 GitHub comments

elasticmachine commented Jan 11, 2024

💔 Build Failed

Build stats

Pipeline error

❕ Flaky test report

🤖 GitHub comments

rdner Jan 12, 2024

Choose a reason for hiding this comment

AndersonQ Jan 12, 2024

Choose a reason for hiding this comment

belimawr Jan 15, 2024

Choose a reason for hiding this comment

AndersonQ Jan 15, 2024

Choose a reason for hiding this comment

belimawr Jan 15, 2024

Choose a reason for hiding this comment

elasticmachine commented Jan 15, 2024

💚 Build Succeeded

Build stats

❕ Flaky test report

🤖 GitHub comments

`Building Beats » Beats Packaging » PR-37579`