Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add test for handling processing errors while publishing events #37491

Merged
merged 1 commit into from
Jan 10, 2024

Conversation

rdner
Copy link
Member

@rdner rdner commented Dec 22, 2023

There were some instances of this code producing infinite loops. Now there is a test case for the processing pipeline covering this.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
    - [ ] I have made corresponding changes to the documentation
    - [ ] I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
    - [ ] I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

How to test this PR locally

cd ./libbeat/publisher/pipeline
go test -run '.*TestClient.*/.*infinite.*'

Related issues

There were some instances of this code producing infinite loops.
Now there is a test case for the processing pipeline covering this.
@rdner rdner added enhancement libbeat backport-skip Skip notification from the automated backport with mergify Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team labels Dec 22, 2023
@rdner rdner self-assigned this Dec 22, 2023
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Dec 22, 2023
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-12-22T16:12:13.996+0000

  • Duration: 142 min 53 sec

Test stats 🧪

Test Results
Failed 0
Passed 28734
Skipped 2015
Total 30749

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@rdner rdner marked this pull request as ready for review January 5, 2024 16:31
@rdner rdner requested a review from a team as a code owner January 5, 2024 16:31
@rdner rdner requested review from fearful-symmetry, leehinman, faec and cmacknz and removed request for fearful-symmetry January 5, 2024 16:31
@rdner rdner enabled auto-merge (squash) January 5, 2024 19:10
@rdner rdner merged commit 635b286 into elastic:main Jan 10, 2024
7 checks passed
@rdner rdner deleted the test-processing-errors branch January 10, 2024 15:16
Scholar-Li pushed a commit to Scholar-Li/beats that referenced this pull request Feb 5, 2024
…tic#37491)

There were some instances of this code producing infinite loops.
Now there is a test case for the processing pipeline covering this.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify enhancement libbeat Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants