Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[beats] reduce log noise #34460

Merged
merged 4 commits into from
Feb 8, 2023

Conversation

klacabane
Copy link
Contributor

Summary

Related #34217

Reduce log noise when failing to get the cluster uuid from a beats state.
If the issue surfaced by this log is persistent it would already be highlighted by higher severity entries in the logs.

@klacabane klacabane added Team:Infra Monitoring UI - DEPRECATED Infrastructure Monitoring UI team - DEPRECATED - Use Team:Monitoring v8.7.0 labels Feb 2, 2023
@klacabane klacabane self-assigned this Feb 2, 2023
@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels Feb 2, 2023
@mergify
Copy link
Contributor

mergify bot commented Feb 2, 2023

This pull request does not have a backport label.
If this is a bug or security fix, could you label this PR @klacabane? 🙏.
For such, you'll need to label your PR with:

  • The upcoming major version of the Elastic Stack
  • The upcoming minor version of the Elastic Stack (if you're not pushing a breaking change)

To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v8./d.0 is the label to automatically backport to the 8./d branch. /d is the digit

@klacabane klacabane added the backport-v8.6.0 Automated backport with mergify label Feb 2, 2023
@elasticmachine
Copy link
Collaborator

elasticmachine commented Feb 2, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-02-02T19:18:31.089+0000

  • Duration: 56 min 38 sec

Test stats 🧪

Test Results
Failed 0
Passed 4284
Skipped 877
Total 5161

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@klacabane klacabane marked this pull request as ready for review February 2, 2023 15:27
@klacabane klacabane requested a review from a team as a code owner February 2, 2023 15:27
@@ -70,6 +73,14 @@ func (m *MetricSet) Fetch(r mb.ReporterV2) error {

clusterUUID, err := m.getClusterUUID()
if err != nil {
if errors.Is(err, beat.ErrClusterUUID) {
if time.Since(m.lastClusterUUIDMessageTimestamp) > 5*time.Minute {
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@klacabane klacabane merged commit 83422d5 into elastic:main Feb 8, 2023
mergify bot pushed a commit that referenced this pull request Feb 8, 2023
(cherry picked from commit 83422d5)
klacabane pushed a commit that referenced this pull request Feb 9, 2023
chrisberkhout pushed a commit that referenced this pull request Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-v8.6.0 Automated backport with mergify Team:Infra Monitoring UI - DEPRECATED Infrastructure Monitoring UI team - DEPRECATED - Use Team:Monitoring v8.7.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants