Skip to content

Commit

Permalink
enabled back tests
Browse files Browse the repository at this point in the history
  • Loading branch information
oakrizan committed Jul 30, 2024
1 parent dc0b701 commit d80ab3b
Show file tree
Hide file tree
Showing 4 changed files with 10 additions and 11 deletions.
4 changes: 2 additions & 2 deletions auditbeat/module/file_integrity/fileinfo_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ import (

func TestNewMetadata(t *testing.T) {
// Can be removed after https://github.com/elastic/beats/issues/37701 is solved
skipOnBuildkiteDarwin(t, "Group check")
//skipOnBuildkiteDarwin(t, "Group check")

f, err := os.CreateTemp(t.TempDir(), "metadata")
if err != nil {
Expand Down Expand Up @@ -99,7 +99,7 @@ func TestNewMetadata(t *testing.T) {

func TestSetUIDSetGIDBits(t *testing.T) {
// Can be removed after https://github.com/elastic/beats/issues/37701 is solved
skipOnBuildkiteDarwin(t, "Wheel permission issue")
//skipOnBuildkiteDarwin(t, "Wheel permission issue")

f, err := os.CreateTemp(t.TempDir(), "setuid")
if err != nil {
Expand Down
12 changes: 6 additions & 6 deletions auditbeat/module/file_integrity/metricset_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -65,9 +65,9 @@ func TestActions(t *testing.T) {
skipOnCIForDarwinAMD64(t)

// Can be removed after https://github.com/elastic/ingest-dev/issues/3016 is solved
skipOnBuildkiteWindows(t)
//skipOnBuildkiteWindows(t)
// Can be removed after https://github.com/elastic/ingest-dev/issues/3076 is solved
skipOnBuildkiteDarwinArm(t)
//skipOnBuildkiteDarwinArm(t)

defer abtest.SetupDataDir(t)()

Expand Down Expand Up @@ -162,9 +162,9 @@ func TestExcludedFiles(t *testing.T) {
skipOnCIForDarwinAMD64(t)

// Can be removed after https://github.com/elastic/ingest-dev/issues/3016 is solved
skipOnBuildkiteWindows(t)
//skipOnBuildkiteWindows(t)
// Can be removed after https://github.com/elastic/ingest-dev/issues/3076 is solved
skipOnBuildkiteDarwinArm(t)
//skipOnBuildkiteDarwinArm(t)

defer abtest.SetupDataDir(t)()

Expand Down Expand Up @@ -214,9 +214,9 @@ func TestIncludedExcludedFiles(t *testing.T) {
skipOnCIForDarwinAMD64(t)

// Can be removed after https://github.com/elastic/ingest-dev/issues/3016 is solved
skipOnBuildkiteWindows(t)
//skipOnBuildkiteWindows(t)
// Can be removed after https://github.com/elastic/ingest-dev/issues/3076 is solved
skipOnBuildkiteDarwinArm(t)
//skipOnBuildkiteDarwinArm(t)

defer abtest.SetupDataDir(t)()

Expand Down
2 changes: 1 addition & 1 deletion metricbeat/module/system/test_system.py
Original file line number Diff line number Diff line change
Expand Up @@ -258,7 +258,7 @@ def test_diskio(self):
self.assertCountEqual(
SYSTEM_DISK_HOST_FIELDS, host_disk.keys())

@unittest.skipUnless(re.match("(?i)win|linux|freebsd|openbsd", sys.platform), "os")
@unittest.skipUnless(re.match("(?i)win|linux|darwin|freebsd|openbsd", sys.platform), "os")
def test_filesystem(self):
"""
Test system/filesystem output.
Expand Down
3 changes: 1 addition & 2 deletions metricbeat/tests/system/test_reload.py
Original file line number Diff line number Diff line change
Expand Up @@ -42,8 +42,7 @@ def test_reload(self):
self.wait_until(lambda: self.output_lines() > 0)
proc.check_kill_and_wait()

# windows is disabled, see https://github.com/elastic/beats/issues/37841
@unittest.skipUnless(re.match("(?i)linux|darwin|freebsd|openbsd", sys.platform), "os")
@unittest.skipUnless(re.match("(?i)win|linux|darwin|freebsd|openbsd", sys.platform), "os")
def test_start_stop(self):
"""
Test if module is properly started and stopped
Expand Down

0 comments on commit d80ab3b

Please sign in to comment.