do not retry when there is malformed data

elastic · Feb 22, 2024 · abeeb33 · abeeb33
1 parent 627bde3
commit abeeb33
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 1 deletion.
diff --git a/heartbeat/monitors/wrappers/monitorstate/esloader.go b/heartbeat/monitors/wrappers/monitorstate/esloader.go
@@ -104,7 +104,7 @@ func MakeESLoader(esc *eslegclient.Connection, indexPattern string, beatLocation
 		err = json.Unmarshal(body, &sh)
 		if err != nil {
 			sErr := fmt.Errorf("could not unmarshal state hits for %s: %w", sf.ID, err)
-			return nil, LoaderError{err: sErr, Retry: true}
+			return nil, LoaderError{err: sErr, Retry: false}
 		}
 
 		if len(sh.Hits.Hits) == 0 {

diff --git a/heartbeat/monitors/wrappers/monitorstate/esloader_test.go b/heartbeat/monitors/wrappers/monitorstate/esloader_test.go
@@ -109,6 +109,11 @@ func TestMakeESLoaderError(t *testing.T) {
 			statusCode: http.StatusNotFound,
 			expected:   false,
 		},
+		{
+			name:       "should not return a retryable error when handling malformed data",
+			statusCode: http.StatusOK,
+			expected:   false,
+		},
 	}
 	for _, test := range tests {
 		t.Run(test.name, func(t *testing.T) {