test: Use automatically created GITHUB_TOKEN for smoketest #524
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reakaleek
reviewed
Jul 31, 2024
.github/workflows/smoke-tests.yml
Outdated
| @@ -20,7 +20,7 @@ jobs: | |||
| test: | |||
| runs-on: ubuntu-latest | |||
| env: | |||
| GH_TOKEN: ${{ github.token }} | |||
| GH_TOKEN: ${{ secrets.GITHUB_TOKEN }} | |||
There was a problem hiding this comment.
I'm afraid this is just another syntax to get the same token.
We would need to grant the token the correct permissions.
However, unfortunately, I don't see appropriate permissions to query the GH user API.
There was a problem hiding this comment.
As an alternative, we could use a machine user token.
or
I don't know the context and what the username is used for, but could we do something like:
if [[ -n "$CI"]]; then
user_name = "github-actions"
else
# ...
fi
There was a problem hiding this comment.
That's a good suggestion. Using a hard-coded user_name in CI should be fine.
The gh tool doesn't has permissions in CI and a using a hard-coded user_name is sufficient.
rockdaboot
force-pushed
the
smoketest-use-github-token
branch
from
57e9562 to
40f6c6b
Compare
reakaleek
approved these changes
Jul 31, 2024
|
@reakaleek Sorry, I messed this up. Fix at #525 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This hopefully fixes the error from
ghin the smoketest: