Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove net 6.0 targets #2498

Merged
merged 8 commits into from
Nov 27, 2024
Merged

Remove net 6.0 targets #2498

merged 8 commits into from
Nov 27, 2024

Conversation

stevejgordon
Copy link
Contributor

@stevejgordon stevejgordon commented Nov 25, 2024

  • Removes unsupported net6.0 targets from libraries and updates build and test projects accordingly.
  • Updates compiler preprocessor directives.
  • Updates a few critical dependencies to ensure the build and CI processes continue functioning.
  • Refactors StartupHookTests to ensure all dotnet commands run on 8.0.404 SDK. This can be updated and automated as part of upgrading to the .NET 9 SDK in a future PR. Additional logging is added when debugging test failures locally.

Closes #2489

@stevejgordon stevejgordon marked this pull request as ready for review November 26, 2024 21:10
@stevejgordon stevejgordon requested review from Mpdreamz and a team November 26, 2024 21:10
Copy link
Member

@Mpdreamz Mpdreamz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm, one thing that comes to mind is to double check all our .dotnet-tools.json dependencies run on .net 8.0.

We might get bit by that during release.

Starting with .net 9 we can control this strict sdk pinning for running dotnet tools by specifying it's safe to run this tool on a later sdk (99.99÷) of the time.

@stevejgordon
Copy link
Contributor Author

Lgtm, one thing that comes to mind is to double check all our .dotnet-tools.json dependencies run on .net 8.0.

We might get bit by that during release.

Starting with .net 9 we can control this strict sdk pinning for running dotnet tools by specifying it's safe to run this tool on a later sdk (99.99÷) of the time.

Good shout! assembly-differ has a specific net8.0 target, so I think that's fine, and minver-cli has the RollForward MSBuild property. As that's been working on the .NET 8 SDK already, I think that should be ok.

@stevejgordon stevejgordon merged commit efa86c4 into main Nov 27, 2024
16 checks passed
@stevejgordon stevejgordon deleted the remove-net6 branch November 27, 2024 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CORE] Drop net6.0 TFM and prefer net8.0
2 participants