Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kswole.lic #1360

Merged
merged 3 commits into from
Nov 27, 2023
Merged

Update kswole.lic #1360

merged 3 commits into from
Nov 27, 2023

Conversation

HebrewToYou
Copy link
Contributor

  • Adding support for some IMT spell preps
  • Checking to ensure that FEAT ABSORB is not on cooldown
  • Checking for 30 stamina or more before using FEAT DISPEL

- Adding support for some IMT spell preps
- Checking to ensure that FEAT ABSORB is not on cooldown
- Checking for 30 stamina or more before using FEAT DISPEL
Fixing a missing space
@HebrewToYou
Copy link
Contributor Author

@GSIV-Nidal - let me know if you have any concerns about these changes

Copy link
Contributor

@mrhoribu mrhoribu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The cooldown issue is due to a bug in Lich 5.7.0's Lich::Util.normalize_lookup method that should get patched in 5.7.1 release. The fix in this script should be good to go till then. The DISPEL MAGIC should already be checking for 30stam but an additional check doesn't hurt it. Otherwise, this looks good!

Removing unnecessary stamina check
@mrhoribu mrhoribu merged commit 082bf86 into elanthia-online:master Nov 27, 2023
6 checks passed
@GSIV-Nidal
Copy link
Contributor

@GSIV-Nidal - let me know if you have any concerns about these changes

hi no issues from my end. The stamina cost on dispel is sneaky because there’s no mention of it in the in game help or the wiki last I checked. Could have sworn core Lich was updated to account for it in .affordable? when this was first discovered for kswole but whatever works, no harm in another check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants