Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bigshot] v5.2.2 bugfix in bs_wander #1355

Merged
merged 4 commits into from
Nov 23, 2023
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 11 additions & 10 deletions scripts/bigshot.lic
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
contributors: SpiffyJr, Tillmen, Kalros, Hazado, Tysong, Athias, Falicor, Deysh, Nisugi
game: Gemstone
tags: hunting, bigshot, combat
version: 5.2.1
version: 5.2.2
required: Lich >= 5.5.0, infomon >= 1.18.11

Setup Instructions: https://gswiki.play.net/Script_Bigshot
Expand All @@ -17,6 +17,9 @@

Version Control:
Major_change.feature_addition.bugfix
v5.2.2 (2023-11-21)
- bugfix causing bs_wander to delay 0.5 seconds longer than needed
- added Roa'ter and Ooze escape check in bs_wander
v5.2.1 (2023-11-15)
- add new efury, caststop, and wield cmd
- redo unravel/barddispel cmd
Expand Down Expand Up @@ -591,14 +594,8 @@ class Bigshot

def all_present?
@members.each_pair { |k, _v|
begin
return false if !checkpcs.include?(k) && k != @leader.name
rescue
@leader.message("yellow", "Error polling member(all_present?). Removing #{k}!")
@members.delete(k)
end
return false unless checkpcs.include?(k)
}
sleep 0.5
return true
end

Expand Down Expand Up @@ -4532,6 +4529,8 @@ class Bigshot
go2(@RESTING_ROOM_ID)
end

escape_rooms

if (@QUIET_FOLLOWERS) && !any_wounded
@followers.add_event(:FOLLOW_NOW)
message("yellow", "Waiting for followers....") if [email protected]_present?
Expand Down Expand Up @@ -4803,6 +4802,7 @@ class Bigshot

def single_stop()
Script.self.kill
sleep 0.5
end

def room_id()
Expand Down Expand Up @@ -5623,10 +5623,10 @@ class Bigshot
else
way.call
end
set_room_claimed([])

escape_rooms
set_room_claimed([])
check_for_deaders_prone

cast_signs(true)
}

Expand Down Expand Up @@ -5675,6 +5675,7 @@ class Bigshot
wait_rt
end

escape_rooms
wait_while { @followers.roundtime? }

if (Char.prof == "Ranger") && !Effects::Cooldowns.active?("Tracking") && !@TRACKING_CREATURE.empty?
Expand Down