-
Notifications
You must be signed in to change notification settings - Fork 179
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[script][combat-trainer] minor necro fix - sequencing issue #7069
Conversation
BEFORE [combat-trainer]>stow my throwing.club [combat-trainer]>perform butcher on snowbeast Since you don't choose a body part to go for, you instead study the snowbeast carefully, and you think that the leg is the best body part to take from this corpse.
Your formation of a targeting pattern around a snowbeast has completed.
[combat-trainer]>drop my snowbeast leg [combat-trainer]>perform dissect on snowbeast Holdigor just arrived. Holdigor runs west.
[combat-trainer]>get my throwing.club [combat-trainer]>arrange for skin [combat-trainer]>dissect snowbeast [combat-trainer]>tap my bundle You tap a tight bundle that you are wearing. [combat-trainer]>skin Bloodwraith Blackspine just arrived.
Bloodwraith Blackspine runs west. [ before fix: the dissect/skin attempts are visible after the dissect in the necro_rituals code block. |
A snowbeast pales and shakes under the strain of your attack! [combat-trainer: Delay from AttackProcess] Your body feels at full strength. [combat-trainer]>stow my throwing.club
You put your club in your carryall. [combat-trainer]>perform butcher on snowbeast
[combat-trainer]>drop my snowbeast leg [combat-trainer]>perform dissect on snowbeast You carefully position the corpse and make a cut across its length, opening up the viscera for your inspection. Using your knife as a probe, you trace the lines of the corpse, cutting into where vital fluids once flowed. You learn something both of the snowbeast and the Great Work through the examination.
[combat-trainer]>get my throwing.club [combat-trainer]>loot treasure [combat-trainer: Delay from LootProcess] After fix: after the necro ritual code block, it goes straight into the loot command. The dissect/skin block is not called. |
Thank you! |
If dissect_and_butcher was true and the butcher ritual is activated, the existing code would perform dissect and butcher correctly, AND it would follow up with an attempt at skin/dissect if configured as such in YAML.
The root cause was a @last_ritual = dissect command being overwritten with @last_ritual = butcher, which caused the skin/dissect code to be called. Proposed fix addresses the root cause completely.