Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[script][combat-trainer] minor necro fix - sequencing issue #7069

Merged
merged 1 commit into from
Jan 22, 2025

Conversation

mdr55
Copy link
Contributor

@mdr55 mdr55 commented Jan 22, 2025

If dissect_and_butcher was true and the butcher ritual is activated, the existing code would perform dissect and butcher correctly, AND it would follow up with an attempt at skin/dissect if configured as such in YAML.

The root cause was a @last_ritual = dissect command being overwritten with @last_ritual = butcher, which caused the skin/dissect code to be called. Proposed fix addresses the root cause completely.

@mdr55
Copy link
Contributor Author

mdr55 commented Jan 22, 2025

BEFORE

[combat-trainer]>stow my throwing.club
You put your club in your carryall.

[combat-trainer]>perform butcher on snowbeast

Since you don't choose a body part to go for, you instead study the snowbeast carefully, and you think that the leg is the best body part to take from this corpse.
You begin to dismember the corpse in front of you.
Making several deep cuts with your knife at key places in the snowbeast's corpse, you manage to extract a passable (3/10) snowbeast leg.
Roundtime: 7 sec.

  • Awkwardly, a snowbeast claws at you. You beat off most of the claw with a polished steel parry stick.
    [You're incredibly balanced and overwhelming your opponent.]

Your formation of a targeting pattern around a snowbeast has completed.

  • Ineptly, a snowbeast bites at you. You block with a lumium round sipar.
    [You're adeptly balanced and overwhelming your opponent.]
  • Moving in like a timid schoolboy, a snowbeast bites at you. You block with a lumium round sipar.
    [You're adeptly balanced and in dominating position.]

[combat-trainer]>drop my snowbeast leg
You discard the snowbeast leg.

[combat-trainer]>perform dissect on snowbeast
You carefully position the corpse and make a cut across its length, opening up the viscera for your inspection. Using your knife as a probe, you trace the lines of the corpse, cutting into where vital fluids once flowed. You learn something both of the snowbeast and the Great Work through the examination.
Roundtime: 8 sec.

Holdigor just arrived.

Holdigor runs west.

  • Apparently without direction or thought, a snowbeast claws at you. You deflect most of the claw with a polished steel parry stick.
    [You're adeptly balanced and in dominating position.]
  • Ineptly, a snowbeast bites at you. You block with a lumium round sipar.
    [You're adeptly balanced and overwhelming your opponent.]
  • Awkwardly, a snowbeast bites at you. You block solidly with a lumium round sipar.
    [You're adeptly balanced and overwhelming your opponent.]

[combat-trainer]>get my throwing.club
You get a steel throwing club from inside your carryall.

[combat-trainer]>arrange for skin
Arrange what?

[combat-trainer]>dissect snowbeast
A failed or completed ritual has rendered this corpse unusable for your purposes.

[combat-trainer]>tap my bundle

You tap a tight bundle that you are wearing.

[combat-trainer]>skin
Skin what?

Bloodwraith Blackspine just arrived.

  • Moving in like a timid schoolboy, a snowbeast bites at you. You beat off most of the teeth with a steel throwing club.
    [You're adeptly balanced and in superior position.]

Bloodwraith Blackspine runs west.

[

before fix: the dissect/skin attempts are visible after the dissect in the necro_rituals code block.

@mdr55
Copy link
Contributor Author

mdr55 commented Jan 22, 2025

A snowbeast pales and shakes under the strain of your attack!
< Driving in like the overwhelming force of a hurricane, you feint a steel throwing club at a snowbeast. A snowbeast fails to evade, moving directly into the blow. The club lands a solid hit (4/23) that blasts hard into the left arm and causes purple welts to appear almost immediately.
A snowbeast lets loose a blood-curdling howl and falls into a heap.
[You're incredibly balanced]
[Roundtime 1 sec.]

[combat-trainer: Delay from AttackProcess]
[combat-trainer: Timer: 1.607915257]
[combat-trainer: END OF PROCESS PASS]
[combat-trainer: STARTING]
[combat-trainer: Timer: 0.100414158]
[combat-trainer: updated @no_gain_list: {"Small Blunt"=>0, "Brawling"=>6}]
[combat-trainer: Delay from SetupProcess]
[combat-trainer: Timer: 0.000337197]
[combat-trainer: Delay from SpellProcess]
[combat-trainer: Timer: 0.000118173]
[combat-trainer: Delay from PetProcess]
[combat-trainer: Timer: 9.9175e-05]
[combat-trainer: Delay from AbilityProcess]
[combat-trainer: Timer: 8.7791e-05]
[combat-trainer]>health
You feel fully prepared to cast your spell.

Your body feels at full strength.
Your spirit feels full of life.
You are slightly fatigued.
You have some minor abrasions to the chest, some minor abrasions to the back.
You have no significant injuries.

[combat-trainer]>stow my throwing.club

  • Ineptly, a snowbeast claws at you. You block solidly with a lumium round sipar.
    [You're incredibly balanced and overwhelming your opponent.]
  • Apparently without direction or thought, a snowbeast claws at you. You block with a lumium round sipar.
    [You're incredibly balanced and overwhelming your opponent.]

You put your club in your carryall.

[combat-trainer]>perform butcher on snowbeast
Since you don't choose a body part to go for, you instead study the snowbeast carefully, and you think that the leg is the best body part to take from this corpse.
You begin to dismember the corpse in front of you.
Making several deep cuts with your knife at key places in the snowbeast's corpse, you manage to extract a passable (3/10) snowbeast leg.
Roundtime: 7 sec.

  • With pathetic timing, a snowbeast claws at you. You knock aside most of the claw with a polished steel parry stick.
    [You're incredibly balanced and overwhelming your opponent.]
  • Looking as if this were a bad idea, a snowbeast claws at you. You fend off most of the claw with a polished steel parry stick.
    [You're incredibly balanced and overwhelming your opponent.]

[combat-trainer]>drop my snowbeast leg
You discard the snowbeast leg.

[combat-trainer]>perform dissect on snowbeast
You feel fully rested.

You carefully position the corpse and make a cut across its length, opening up the viscera for your inspection. Using your knife as a probe, you trace the lines of the corpse, cutting into where vital fluids once flowed. You learn something both of the snowbeast and the Great Work through the examination.
Roundtime: 8 sec.

  • Tentatively, a snowbeast claws at you. You block with a lumium round sipar.
    [You're adeptly balanced and overwhelming your opponent.]
  • Apparently without direction or thought, a snowbeast claws at you. You counter most of the claw with a polished steel parry stick.
    [You're adeptly balanced and overwhelming your opponent.]
  • In a weak and directionless display of aggression, a snowbeast claws at you. You counter most of the claw with a polished steel parry stick.
    [You're adeptly balanced and overwhelming your opponent.]
  • With pathetic timing, a snowbeast claws at you. You block with a lumium round sipar.
    [You're nimbly balanced and in dominating position.]

[combat-trainer]>get my throwing.club
You get a steel throwing club from inside your carryall.

[combat-trainer]>loot treasure
You search the snowbeast.
You find nothing of interest.

[combat-trainer: Delay from LootProcess]
[combat-trainer: Timer: 16.666860423]
[combat-trainer: Delay from ManipulateProcess]
[combat-trainer: Timer: 0.000286282]
[combat-trainer]>weave
You turn to face a snowbeast.
You weave back and forth in a dance-like motion, drawing your opponent's attention away from the fight.
[You're adeptly balanced and in dominating position.]

After fix: after the necro ritual code block, it goes straight into the loot command. The dissect/skin block is not called.

@MahtraDR MahtraDR merged commit 3b0a717 into elanthia-online:main Jan 22, 2025
2 checks passed
@MahtraDR
Copy link
Collaborator

Thank you!

@mdr55 mdr55 deleted the necro-fix branch January 23, 2025 04:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants