Merge pull request #2 from glensc/connect-timeout

implement connect timeout parameter
ekspress-grupp · Oct 4, 2017 · 9b30536 · 9b30536
2 parents d70f567 + 64d8149
commit 9b30536
Show file tree

Hide file tree

Showing 2 changed files with 39 additions and 6 deletions.
diff --git a/rdb/Connection.php b/rdb/Connection.php
@@ -22,16 +22,28 @@ class Connection extends DatumConverter
     private $password;
     private $activeTokens;
     private $timeout;
+    private $connectTimeout;
     private $ssl;
 
     public $defaultDbName;
 
+	/**
+	 * @param array|string $optsOrHost
+	 * @param int $port
+	 * @param string $db
+	 * @param string $apiKey
+	 * @param int $timeout
+	 * @param int $connectTimeout
+	 * @throws RqlDriverError
+	 * @throws \Exception
+	 */
     public function __construct(
         $optsOrHost = null,
         $port = null,
         $db = null,
         $apiKey = null,
-        $timeout = null
+        $timeout = null,
+        $connectTimeout = null
     ) {
         if (is_array($optsOrHost)) {
             $opts = $optsOrHost;
@@ -67,6 +79,9 @@ public function __construct(
             if (isset($opts['timeout'])) {
                 $timeout = $opts['timeout'];
             }
+            if (isset($opts['connectTimeout'])) {
+	            $connectTimeout = $opts['connectTimeout'];
+            }
             if (isset($opts['ssl'])) {
                 $ssl = $opts['ssl'];
             }
@@ -106,6 +121,7 @@ public function __construct(
         $this->user = $user;
         $this->password = $password;
         $this->timeout = null;
+        $this->connectTimeout = $connectTimeout ?: ini_get("default_socket_timeout");
         $this->ssl = $ssl;
 
         if (isset($db)) {
@@ -430,6 +446,10 @@ private function applyTimeout($timeout)
         }
     }
 
+	/**
+	 * @throws RqlDriverError
+	 * @throws \Exception
+	 */
     private function connect()
     {
         if ($this->isOpen()) {
@@ -446,12 +466,14 @@ private function connect()
                 "ssl://" . $this->host . ":" . $this->port,
                 $errno,
                 $errstr,
-                ini_get("default_socket_timeout"),
+                $this->connectTimeout,
                 STREAM_CLIENT_CONNECT,
                 $context
             );
         } else {
-            $this->socket = stream_socket_client("tcp://" . $this->host . ":" . $this->port, $errno, $errstr);
+            $this->socket = stream_socket_client("tcp://" . $this->host . ":" . $this->port, $errno, $errstr,
+	            $this->connectTimeout
+            );
         }
         if ($errno != 0 || $this->socket === false) {
             $this->socket = null;

diff --git a/rdb/global.php b/rdb/global.php
@@ -82,9 +82,20 @@
 
 // ------------- Global functions in namespace r -------------
 
-function connect($optsOrHost = null, $port = null, $db = null, $apiKey = null, $timeout = null)
-{
-    return new Connection($optsOrHost, $port, $db, $apiKey, $timeout);
+/**
+ * @param array|string $optsOrHost
+ * @param int $port
+ * @param string $db
+ * @param string $apiKey
+ * @param int $timeout
+ * @param int $connectTimeout
+ * @return Connection
+ * @throws RqlDriverError
+ * @throws \Exception
+ */
+function connect($optsOrHost = null, $port = null, $db = null, $apiKey = null, $timeout = null, $connectTimeout = null)
+{
+    return new Connection($optsOrHost, $port, $db, $apiKey, $timeout, $connectTimeout);
 }
 
 function db($dbName)