Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ignore all twitter links when checking links #2959

Merged
merged 1 commit into from
Dec 17, 2020
Merged

ignore all twitter links when checking links #2959

merged 1 commit into from
Dec 17, 2020

Conversation

aclevername
Copy link
Contributor

@aclevername aclevername commented Dec 17, 2020 •
edited
Loading

Description

We are getting failures in link-checker for twitter links. Related issue: raviqqe/liche#48

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Added labels for change area (e.g. area/nodegroup), target version (e.g. version/0.12.0) and kind (e.g. kind/improvement)
  • Make sure the title of the PR is a good description that can go into the release notes

@aclevername aclevername added the skip-release-notes Causes PR not to show in release notes label Dec 17, 2020
@aclevername aclevername merged commit 4674a0a into master Dec 17, 2020
@aclevername aclevername deleted the link-checker branch December 17, 2020 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Callisto13 Callisto13 Callisto13 approved these changes

Assignees
No one assigned
Labels
kind/bug skip-release-notes Causes PR not to show in release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aclevername @Callisto13